Bug 1040452 - 3rdparty/double-convertion is too old for AArch64
Summary: 3rdparty/double-convertion is too old for AArch64
Keywords:
Status: CLOSED DUPLICATE of bug 1056051
Alias: None
Product: Fedora
Classification: Fedora
Component: qt5-qtdeclarative
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Than Ngo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-11 13:08 UTC by Marcin Juszkiewicz
Modified: 2014-02-02 21:25 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-02 21:25:13 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
upstream (doube-convertion) patch to add AArch64 support (1.10 KB, patch)
2013-12-11 13:08 UTC, Marcin Juszkiewicz 		no flags Details | Diff
complete fix (4.40 KB, patch)
2014-01-03 14:26 UTC, Marcin Juszkiewicz 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Qt Bug Tracker QTBUG-35528 0 None None None Never

Description Marcin Juszkiewicz 2013-12-11 13:08:04 UTC 
Created attachment 835275 [details]
upstream (doube-convertion) patch to add AArch64 support

Description of problem:

DEBUG: ../3rdparty/masm/jit/../../../3rdparty/double-conversion/utils.h:77:2: error: #error Target architecture was not detected as supported by Double-Conversion.

Version-Release number of selected component (if applicable):

5.2.0-rc1

How reproducible:

just try to build on aarch64

Actual results:

DEBUG: ../3rdparty/masm/jit/../../../3rdparty/double-conversion/utils.h:77:2: error: #error Target architecture was not detected as supported by Double-Conversion.

Expected results:

package builds

Additional info:

upstream reported: https://bugreports.qt-project.org/browse/QTBUG-35528
Comment 1 Marcin Juszkiewicz 2013-12-16 09:31:12 UTC 
Real upstream issue was https://code.google.com/p/double-conversion/issues/detail?id=33 

They wrote patch with wrong definition name so build fails.
Comment 2 Marcin Juszkiewicz 2014-01-03 13:53:50 UTC 
https://code.google.com/p/double-conversion/source/detail?r=4e24bb31bcc76d6d218f3056b4c24a109d367561&name=branch_v2.0 is upstream/upstream fix.
Comment 3 Marcin Juszkiewicz 2014-01-03 14:26:30 UTC 
Created attachment 844961 [details]
complete fix

This patch adds both upstream changes which are required. The only difference between patches and upstream are path changes and Changelog part stripped off from second one.

With those changes it builds fine.
Comment 4 Rex Dieter 2014-02-02 21:25:13 UTC 

*** This bug has been marked as a duplicate of bug 1056051 ***
Note You need to log in before you can comment on or make changes to this bug.