Bug 1043566

Summary:	Updating glusterfs packages reads 'rpmsave' files created by previous updates, and saves the files as <file>.rpmsave.rpmsave.
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Vimal Kumar <vikumar>
Component:	glusterfs	Assignee:	Poornima G <pgurusid>
Status:	CLOSED EOL	QA Contact:	SATHEESARAN <sasundar>
Severity:	high	Docs Contact:
Priority:	medium
Version:	2.1	CC:	asrivast, bhubbard, hamiller, lmohanty, mzywusko, nsathyan, rtalur, sasundar, sbhaloth, vagarwal, vbellur, vikumar
Target Milestone:	---	Keywords:	Reopened
Target Release:	RHGS 3.0.0
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.6.0.25-1	Doc Type:	Bug Fix
Doc Text:	Previously, on upgrade of glusterfs-server package, existing rpmsave files of hook scripts in /var/lib/glusterd/hooks/1/ directory would get re-saved with a ".rpmsave" suffix appended resulting in multiple rpmsave files. With this fix, the hook scripts are treated as config files of the package glusterfs-server and are saved in a RPM standard way.	Story Points:	---
Clone Of:
Clones:	1081870 (view as bug list)		Environment:
Last Closed:	2015-11-30 17:43:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1081870

Description Vimal Kumar 2013-12-16 16:30:13 UTC

1) Description of problem:

Updating glusterfs packages reads the '.rpmsave' files which are kept by the previous updates, and saves the new files as <file>.rpmsave.rpmsave.

2) Version-Release number of selected component (if applicable):

RHS2.1
glusterfs-server-3.4.0.44rhs-1.el6rhs.x86_64 

3) How reproducible:

Always

4) Steps to Reproduce:

	a) Update the glusterfs packages via yum.
	b) The following messages gets written to stdout on updating :

<snip>
warning: /var/lib/glusterd/hooks/1/stop/pre/S30samba-stop.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S29CTDB-teardown.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/set/post/S30samba-set.sh saved as /var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S29CTDBsetup.sh saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave
</snip>

5) Actual results:

For each update, the '.rpmsave' files get saved with an extension of '.rpmsave' which ends up with files naming <files>.rpmsave.rpmsave.

6) Expected results:

The files with '.rpmsave' extension should be overwritten instead of appending another '.rpmsave' extension.

Comment 1 SATHEESARAN 2014-02-13 20:34:16 UTC

The same issue is characterized, while performing a upgrade followed by downgrade

Performed following steps,
1. Upgraded RHSS 2.1 Update1 to RHSS2.1 Update2
2. Again downgraded to Update1
3. I could see that existing files rpmsaves are saved as "rpmsave.rpmsave"

<snip>
warning: /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S29CTDB-teardown.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S30samba-stop.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S29CTDBsetup.sh saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave saved as /var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave.rpmsave
</snip>

Comment 2 Vivek Agarwal 2014-02-20 08:36:52 UTC

adding 3.0 flag and removing 2.1.z

Comment 3 Lalatendu Mohanty 2014-02-20 10:38:15 UTC

*** Bug 1067297 has been marked as a duplicate of this bug. ***

Comment 4 Poornima G 2014-05-27 10:00:56 UTC

Posted for review at https://code.engineering.redhat.com/gerrit/#/c/25729/1

Comment 5 ssamanta 2014-05-30 08:43:03 UTC

Based on discussion with PM, Dev, QE approving this BZ to bring to RHS3.0(Denali)

Comment 6 Poornima G 2014-06-02 07:02:28 UTC

Fixed in glusterfs version 3.6.0.11-1.

Comment 9 surabhi 2014-08-26 11:38:14 UTC

Executed the upgrade tests with the changes in hook script and with multiple updates ,now the last modified hook script gets saved as S29CTDBsetup.sh.rpmsave and there will be a new hook script.
Verified with version glusterfs-3.6.0.27-1.el6rhs.x86_64

Comment 11 errata-xmlrpc 2014-09-22 19:30:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-1278.html

Comment 12 Brad Hubbard 2015-02-28 09:23:21 UTC

Reopening this as it is still a bug in 2.1. If you wish to fix a 2.1 bug in 3 then clone the bug to 3 first. Do not close a 2.1 bug as fixed in 3 because that doesn't fix it in 2.1 and we just have to reopen the bug, thanks.

# rpm -q glusterfs
glusterfs-3.4.0.72rhs-1.el6rhs.x86_64

# pwd
/var/lib/glusterd/hooks/1

# find
.
./start
./start/pre
./start/post
./start/post/S30samba-start.sh
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/S29CTDBsetup.sh
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave
./start/post/K29CTDBsetup.sh.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./remove-brick
./remove-brick/pre
./remove-brick/post
./delete
./delete/pre
./delete/post
./add-brick
./add-brick/pre
./add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave.rpmsave
./add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave
./add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./add-brick/pre/K28Quota-enable-root-xattr-heal.sh.rpmsave
./add-brick/pre/S28Quota-enable-root-xattr-heal.sh
./add-brick/post
./add-brick/post/disabled-quota-root-xattr-heal.sh
./add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave
./add-brick/post/disabled-quota-root-xattr-heal.sh.rpmsave.rpmsave.rpmsave
./set
./set/pre
./set/post
./set/post/K30samba-set.sh.rpmsave
./set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./set/post/K30samba-set.sh.rpmsave.rpmsave
./set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave
./set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./set/post/S30samba-set.sh
./set/post/K30samba-set.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop
./stop/pre
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/S30samba-stop.sh
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K30samba-stop.sh.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave
./stop/pre/S29CTDB-teardown.sh
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
./stop/post
./create
./create/pre
./create/post
./gsync-create
./gsync-create/pre
./gsync-create/post
./gsync-create/post/S56glusterd-geo-rep-create-post.sh

  Updating   : device-mapper-libs-1.02.77-9.el6_4.4.x86_64               22/120 
  Updating   : device-mapper-event-libs-1.02.77-9.el6_4.4.x86_64         23/120 
  Updating   : device-mapper-event-1.02.77-9.el6_4.4.x86_64              24/120 
  Updating   : lvm2-libs-2.02.98-9.el6_4.4.x86_64                        25/120 
  Updating   : glusterfs-server-3.4.0.72rhs-1.el6rhs.x86_64              26/120Non-fatal POSTIN scriptlet failure in rpm package glusterfs-server-3.4.0.72rhs-1.el6rhs.x86_64
 
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsa
ve.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S29CTDBsetup.sh saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.r
pmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S30samba-stop.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S29CTDB-teardown.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpmsave.rpm
save

Comment 18 Harold Miller 2015-11-30 17:43:06 UTC

RHGS 2.1.x is EOL. Closing this BZ as EOL, please open a new BZ if this issue is seen on RHGS 3.x