Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1081870

Summary:	Updating glusterfs packages reads 'rpmsave' files created by previous updates, and saves the files as <file>.rpmsave.rpmsave.
Product:	[Community] GlusterFS	Reporter:	Poornima G <pgurusid>
Component:	build	Assignee:	Ric Wheeler <rwheeler>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	high	Docs Contact:
Priority:	medium
Version:	pre-release	CC:	gluster-bugs, lmohanty, sasundar, vbellur, vikumar
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1043566	Environment:
Last Closed:	2014-06-10 11:00:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1043566
Bug Blocks:

Description Poornima G 2014-03-28 06:27:36 UTC

+++ This bug was initially created as a clone of Bug #1043566 +++

1) Description of problem:

Updating glusterfs packages reads the '.rpmsave' files which are kept by the previous updates, and saves the new files as <file>.rpmsave.rpmsave.

2) Version-Release number of selected component (if applicable):

RHS2.1
glusterfs-server-3.4.0.44rhs-1.el6rhs.x86_64 

3) How reproducible:

Always

4) Steps to Reproduce:

	a) Update the glusterfs packages via yum.
	b) The following messages gets written to stdout on updating :

<snip>
warning: /var/lib/glusterd/hooks/1/stop/pre/S30samba-stop.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S29CTDB-teardown.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/set/post/S30samba-set.sh saved as /var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S29CTDBsetup.sh saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave
</snip>

5) Actual results:

For each update, the '.rpmsave' files get saved with an extension of '.rpmsave' which ends up with files naming <files>.rpmsave.rpmsave.

6) Expected results:

The files with '.rpmsave' extension should be overwritten instead of appending another '.rpmsave' extension.

--- Additional comment from SATHEESARAN on 2014-02-13 15:34:16 EST ---

The same issue is characterized, while performing a upgrade followed by downgrade

Performed following steps,
1. Upgraded RHSS 2.1 Update1 to RHSS2.1 Update2
2. Again downgraded to Update1
3. I could see that existing files rpmsaves are saved as "rpmsave.rpmsave"

<snip>
warning: /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S29CTDB-teardown.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/S30samba-stop.sh saved as /var/lib/glusterd/hooks/1/stop/pre/K30samba-stop.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave saved as /var/lib/glusterd/hooks/1/stop/pre/K29CTDB-teardown.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S29CTDBsetup.sh saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave saved as /var/lib/glusterd/hooks/1/start/post/K29CTDBsetup.sh.rpmsave.rpmsave
warning: /var/lib/glusterd/hooks/1/start/post/S30samba-start.sh saved as /var/lib/glusterd/hooks/1/start/post/K30samba-start.sh.rpmsave
warning: /var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave saved as /var/lib/glusterd/hooks/1/set/post/K30samba-set.sh.rpmsave.rpmsave
</snip>

--- Additional comment from Vivek Agarwal on 2014-02-20 03:36:52 EST ---

adding 3.0 flag and removing 2.1.z

--- Additional comment from Lalatendu Mohanty on 2014-02-20 05:38:15 EST ---

Comment 1 Anand Avati 2014-03-28 06:28:51 UTC

REVIEW: http://review.gluster.org/7362 (rpm: Rename old hookscripts in an RPM-standard way.) posted (#1) for review on master by Poornima G (pgurusid)

Comment 3 Poornima G 2014-06-10 11:00:05 UTC

Change Merged