Bug 1044580
| Summary: | KeyError: 'EPEL5': FedoraReview/plugins/generic_should.py", line 80 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jiri Popelka <jpopelka> | ||||
| Component: | fedora-review | Assignee: | Stanislav Ochotnicky <sochotni> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 20 | CC: | bugs.michael, dridi.boukelmoune, fedora, fedora, ignatenko, jpeeler, leamas.alec, orion, pingou, sochotni | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | noarch | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | fedora-review-0.5.1-2.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-01-15 06:02:43 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1023848 | ||||||
| Attachments: |
|
||||||
|
Description
Jiri Popelka
2013-12-18 15:34:45 UTC
Hmm, I can't reproduce this though I have some idea why this might happen. Will need to look into it more Ran "fedora-review -b 1012391" and got the same traceback. Even "fedora-review --display-flags" fails:
12-24 11:43 root DEBUG fedora-review 0.5.1 bb9bf27 2013-12-13 12:40:49 +0100 started
12-24 11:43 root DEBUG Command line: /usr/bin/fedora-review --display-flags
12-24 11:43 root DEBUG Exception down the road...
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 232, in run
self._do_run(outfile)
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 202, in _do_run
self._list_flags()
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 124, in _list_flags
checks_lister = ChecksLister()
File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 258, in __init__
_ChecksLoader.__init__(self)
File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 166, in __init__
self._load_checks()
File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 204, in _load_checks
tests = registry.register(plugin)
File "/usr/lib/python2.7/site-packages/FedoraReview/registry.py", line 130, in register
obj = (c[1])(self.checks)
File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_should.py", line 80, in __init__
if self.flags['EPEL5']:
KeyError: 'EPEL5'
12-24 11:43 root ERROR Exception down the road...(logs in /home/ms20b/.cache/fedora-review.log)
12-24 11:43 root DEBUG Report completed: 0.023 seconds
$ fedora-review -d
ERROR: Exception down the road...(logs in /home/ms20b/.cache/fedora-review.log)
Same there.
Using "yum downgrade fedora-review" as a work-around. Installing : fedora-review-0.5.0-3.fc20.noarch 1/2 Cleanup : fedora-review-0.5.1-1.fc20.noarch 2/2 Verifying : fedora-review-0.5.0-3.fc20.noarch 1/2 Verifying : fedora-review-0.5.1-1.fc20.noarch 2/2 *** Bug 1046917 has been marked as a duplicate of this bug. *** I have checked in a fix for this on the devel and release-0.5.1 branches: https://git.fedorahosted.org/cgit/FedoraReview.git/commit/?id=c348fe6ff9ac6bd40961d565a3fc76aecbd92a1a It's not fully verified, but is ATM in the Works For Me (TM) state. yes.this patch fixes bug. Thanks. ;) I've wrote bad patch. This fix seems to have worked for me as well. Seems to fix it for me too, though I'm seeing a new error as well. Same issue on F19. Patch from comment #6 also fixes the issue, "for me"(tm) fedora-review-0.5.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-2.fc20 fedora-review-0.5.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-2.fc19 fedora-review-0.5.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.5.1-2.el6 Package fedora-review-0.5.1-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing fedora-review-0.5.1-2.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-0153/fedora-review-0.5.1-2.el6 then log in and leave karma (feedback). fedora-review-0.5.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. *** Bug 1053678 has been marked as a duplicate of this bug. *** fedora-review-0.5.1-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. fedora-review-0.5.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |