Bug 1045117

Summary:	Creating a project floods git with 22 uncommented commits
Product:	[Retired] JBoss BRMS Platform 6	Reporter:	Zuzana Krejčová <zkrejcov>
Component:	Business Central	Assignee:	Alexandre Porcelli <porcelli>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lukáš Petrovický <lpetrovi>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.0.0	CC:	etirelli, lpetrovi, porcelli, vigoyal
Target Milestone:	ER2
Target Release:	6.0.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Known Issue
Doc Text:	Cause: The business-central creates a commit in the underlying Git repository for each new file. Consequence: Creating a new project means adding new files and also filling some with content, which results in 22 commits, each without a comment. Workaround (if any): None. Result: The Git repository is messy. Developers working with it will have a much harder time making sense of who did what and why.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-06 19:57:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zuzana Krejčová 2013-12-19 16:04:33 UTC

Description of problem:
See also bug 1021406.
Creating a project is one atomic operation from a user's viewpoint (no matter what kind of a user). One atomic operation should also mean one git commit. Instead, business-central creates 22(!) commits. Unnecessary, not even commented, messy, nonsensical.

Just to make this clear enough...
commit #1: created resourceName/src/main/java/.gitignore with line '# empty'
commit #2: created empty resourceName/src/main/.java
commit #3: created resourceName/src/main/resources/.gitignore with line '# empty'
commit #4: created empty resourceName/src/main/.resources
commit #5: created resourceName/src/test/java/.gitignore with line '# empty'
commit #6: created empty resourceName/src/test/.java
commit #7: created resourceName/src/test/resources/.gitignore with line '# empty'
commit #8: created empty resourceName/src/test/.resources
commit #9: created empty resourceName/src/main/resources/META-INF/kmodule.xml
commit #10: filled resourceName/src/main/resources/META-INF/kmodule.xml with '<kmodule...'
commit #11: created empty resourceName/pom.xml
commit #12: filled resourceName/pom.xml with '<?xml...'
commit #13: created empty resourceName/project.imports
commit #14: filled resourceName/project.imports with '<configuration>...'
commit #15: created resourceName/src/main/java/project/group/projectartifact/.gitignore with line '# empty'
commit #16: created empty resourceName/src/main/java/project/group/.projectartifact
commit #17: created resourceName/src/test/java/project/group/projectartifact/.gitignore with line '# empty'
commit #18: created empty resourceName/src/test/java/project/group/.projectartifact
commit #19: created resourceName/src/main/resources/project/group/projectartifact/.gitignore with line '# empty'
commit #20: created empty resourceName/src/main/resources/project/group/.projectartifact
commit #21: created resourceName/src/test/resources/project/group/projectartifact/.gitignore with line '# empty'
commit #22: created empty resourceName/src/test/resources/project/group/.projectartifact
All of this means only that one project was created.

Things to fix:
1. Make it one commit.
2. Add a comment.

As a side note - I'd understand the heavy load of .gitignore files, empty .<dir> files don't make sense to me.

Version-Release number of selected component (if applicable):
BPMS 6.0 ER5

Comment 1 manstis 2013-12-19 19:03:28 UTC

I think you completed the change for batch commits when creating a new project?

Comment 2 Alexandre Porcelli 2014-02-10 18:26:40 UTC

Issue fixed on master and product branches:

(master) http://github.com/uberfire/uberfire/commit/597618ec2
(0.3.x) http://github.com/uberfire/uberfire/commit/bdf000568

(master)  http://github.com/droolsjbpm/guvnor/commit/a8ba1bbe8
(6.0.x)   http://github.com/droolsjbpm/guvnor/commit/772ed616c

Comment 3 Zuzana Krejčová 2014-02-21 09:10:03 UTC

Commits are not in the ER1 build.

Comment 4 Lukáš Petrovický 2014-03-05 18:10:13 UTC

Projects are now created in one commit and the commit is commented. VERIFIED with ER2.

commit 2aa06165653f30d657e775d7c007843b6768596b
Author: testadmin <>
Date:   Wed Mar 5 06:35:08 2014 -0500

    New project [smokeproject]