Bug 1045117 - Creating a project floods git with 22 uncommented commits
Summary: Creating a project floods git with 22 uncommented commits
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ER2
: 6.0.1
Assignee: Alexandre Porcelli
QA Contact: Lukáš Petrovický
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-19 16:04 UTC by Zuzana Krejčová
Modified: 2014-08-06 19:57 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-08-06 19:57:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Zuzana Krejčová 2013-12-19 16:04:33 UTC
Description of problem:
See also bug 1021406.
Creating a project is one atomic operation from a user's viewpoint (no matter what kind of a user). One atomic operation should also mean one git commit. Instead, business-central creates 22(!) commits. Unnecessary, not even commented, messy, nonsensical.

Just to make this clear enough...
commit #1:   created resourceName/src/main/java/.gitignore with line '# empty'
commit #2:   created empty resourceName/src/main/.java
commit #3:   created resourceName/src/main/resources/.gitignore with line '# empty'
commit #4:   created empty resourceName/src/main/.resources
commit #5:   created resourceName/src/test/java/.gitignore with line '# empty'
commit #6:   created empty resourceName/src/test/.java
commit #7:   created resourceName/src/test/resources/.gitignore with line '# empty'
commit #8:   created empty resourceName/src/test/.resources
commit #9:   created empty resourceName/src/main/resources/META-INF/kmodule.xml
commit #10:  filled resourceName/src/main/resources/META-INF/kmodule.xml with '<kmodule...'
commit #11:  created empty resourceName/pom.xml
commit #12:  filled resourceName/pom.xml with '<?xml...'
commit #13:  created empty resourceName/project.imports
commit #14:  filled resourceName/project.imports with '<configuration>...' 
commit #15:  created resourceName/src/main/java/project/group/projectartifact/.gitignore with line '# empty'
commit #16:  created empty resourceName/src/main/java/project/group/.projectartifact
commit #17:  created resourceName/src/test/java/project/group/projectartifact/.gitignore with line '# empty'
commit #18:  created empty resourceName/src/test/java/project/group/.projectartifact
commit #19:  created resourceName/src/main/resources/project/group/projectartifact/.gitignore with line '# empty'
commit #20:  created empty resourceName/src/main/resources/project/group/.projectartifact
commit #21:  created resourceName/src/test/resources/project/group/projectartifact/.gitignore with line '# empty'
commit #22:  created empty resourceName/src/test/resources/project/group/.projectartifact
All of this means only that one project was created.


Things to fix:
1. Make it one commit.
2. Add a comment.

As a side note - I'd understand the heavy load of .gitignore files, empty .<dir> files don't make sense to me.


Version-Release number of selected component (if applicable):
BPMS 6.0 ER5

Comment 1 manstis 2013-12-19 19:03:28 UTC
I think you completed the change for batch commits when creating a new project?

Comment 3 Zuzana Krejčová 2014-02-21 09:10:03 UTC
Commits are not in the ER1 build.

Comment 4 Lukáš Petrovický 2014-03-05 18:10:13 UTC
Projects are now created in one commit and the commit is commented. VERIFIED with ER2.

commit 2aa06165653f30d657e775d7c007843b6768596b
Author: testadmin <>
Date:   Wed Mar 5 06:35:08 2014 -0500

    New project [smokeproject]


Note You need to log in before you can comment on or make changes to this bug.