Bug 1045463

Summary: processing instructions contained in PO files are incorrectly stripped
Product: [Community] Publican Reporter: Raphaël Hertzog <raphael>
Component: publicanAssignee: Jeff Fearn 🐞 <jfearn>
Status: CLOSED CURRENTRELEASE QA Contact: Ruediger Landmann <rlandman>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.2CC: aigao, rlandman
Target Milestone: 4.1   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: 4.1.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-05 06:03:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Description Flags
Possible patch none

Description Raphaël Hertzog 2013-12-20 13:50:18 UTC
This is very much like https://bugzilla.redhat.com/show_bug.cgi?id=819420 except that it concerns translations instead of the original document.

Description: When I add some processing instructions in some translated strings (i.e. in a msgid in a PO file), it doesn't get carried over to the generated XML files. The processing instruction is neither present in the tmp/<lang>/xml/* files nor in the tmp/<lang>/xml_tmp/* files (so it's lost even earlier than #819420 IIRC).

Expected result: The processing instructions should be kept.

Comment 1 Raphaël Hertzog 2013-12-20 14:26:11 UTC
Created attachment 839576 [details]
Possible patch

This patch works for me. But maybe the better fix is to enhance Publican::new_tree() to always call $xml_doc->store_pis(1) given that I don't see any place where we really want to drop processing instructions.

Comment 2 Jeff Fearn 🐞 2014-01-06 00:07:03 UTC
Hey Rudi, do we want to allow translators to set processing instructions?

Comment 3 Ruediger Landmann 2014-02-25 05:12:53 UTC

Comment 4 Jeff Fearn 🐞 2014-03-03 22:53:14 UTC
Added store_pis call to Publican::new_tree().

To ssh://git.fedorahosted.org/git/publican.git
   8cf3d60..62b41f3  devel -> devel

Comment 5 Jeff Fearn 🐞 2014-05-05 06:03:29 UTC
A fix for this shipped in Publican 4.1.0.