Bug 1046842
| Summary: | Review Request: python-ofxparse - Python library for working with the Open Financial Exchange file format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Callaghan <dcallagh> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-ofxparse-0.14-2.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-17 05:46:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dan Callaghan
2013-12-27 05:29:18 UTC
Review:
+ Mock build successful for rawhide x86_64
+ rpmlint on generated rpms is
python3-ofxparse.noarch: W: spelling-error %description -l en_US ofx -> fox, of, ox
python-ofxparse.noarch: W: spelling-error %description -l en_US ofx -> fox, of, ox
python-ofxparse.src: W: spelling-error %description -l en_US ofx -> fox, of, ox
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
+ Source verified with upstream as (sha256sum)
upstream tarball: d8c486126a94d912442d040121db44fbc4a646ea70fa935df33b5b4dbfbbe42a
srpm tarball: d8c486126a94d912442d040121db44fbc4a646ea70fa935df33b5b4dbfbbe42a
+ License is valid and included in LICENSE file
Suggestions:
1) I will not block this review for %{python_sitelib} which should have been written as %{python2_sitelib} and same for %{__python} to %{__python2}
you can check these python2 macros are already on the system /etc/rpm/macros.python2
but you should use python2 macros actually.
APPROVED.
(In reply to Parag AN(पराग) from comment #1) > Suggestions: > 1) I will not block this review for %{python_sitelib} which should have been > written as %{python2_sitelib} and same for %{__python} to %{__python2} Thanks for the tip, I missed this change in the guidelines. I was going to target EPEL6 for this package so I will change it to use %{__python2} with some suitable conditionals when I import the package. And thanks for the review :-) New Package SCM Request ======================= Package Name: python-ofxparse Short Description: Python library for working with the Open Financial Exchange file format Owners: dcallagh Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). python-ofxparse-0.14-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-ofxparse-0.14-2.fc20 python-ofxparse-0.14-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-ofxparse-0.14-2.fc19 EPEL6 build is coming soon, it needs patches to fix a build failure but I'm going to wait for upstream's opinion first: https://github.com/jseutter/ofxparse/pull/65 python-ofxparse-0.14-2.fc20 has been pushed to the Fedora 20 testing repository. python-ofxparse-0.14-2.fc20 has been pushed to the Fedora 20 stable repository. python-ofxparse-0.14-2.fc19 has been pushed to the Fedora 19 stable repository. |