Bug 1046842 - Review Request: python-ofxparse - Python library for working with the Open Financial Exchange file format
Summary: Review Request: python-ofxparse - Python library for working with the Open Fi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-12-27 05:29 UTC by Dan Callaghan
Modified: 2014-01-17 05:52 UTC (History)
2 users (show)

Fixed In Version: python-ofxparse-0.14-2.fc20
Clone Of:
Environment:
Last Closed: 2014-01-17 05:46:53 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Dan Callaghan 2013-12-27 05:29:18 UTC
Spec URL: http://fedorapeople.org/~dcallagh/python-ofxparse/python-ofxparse.spec
SRPM URL: http://fedorapeople.org/~dcallagh/python-ofxparse/python-ofxparse-0.14-1.fc19.src.rpm
Description: This library is a parser for Open Financial Exchange (.ofx) format files. OFX files are available from almost any online banking site, so they work well if you want to pull together your finances from multiple sources. Online trading accounts also provide account statements in OFX files.
Fedora Account System Username: dcallagh

Comment 1 Parag AN(पराग) 2013-12-27 06:25:12 UTC
Review:

+ Mock build successful for rawhide x86_64

+ rpmlint on generated rpms is
python3-ofxparse.noarch: W: spelling-error %description -l en_US ofx -> fox, of, ox
python-ofxparse.noarch: W: spelling-error %description -l en_US ofx -> fox, of, ox
python-ofxparse.src: W: spelling-error %description -l en_US ofx -> fox, of, ox
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
upstream tarball: d8c486126a94d912442d040121db44fbc4a646ea70fa935df33b5b4dbfbbe42a
srpm tarball: d8c486126a94d912442d040121db44fbc4a646ea70fa935df33b5b4dbfbbe42a

+ License is valid and included in LICENSE file

Suggestions:
1) I will not block this review for %{python_sitelib} which should have been written as %{python2_sitelib} and same for %{__python} to %{__python2}

you can check these python2 macros are already on the system /etc/rpm/macros.python2

but you should use python2 macros actually.


APPROVED.

Comment 2 Dan Callaghan 2014-01-02 22:40:47 UTC
(In reply to Parag AN(पराग) from comment #1)
> Suggestions:
> 1) I will not block this review for %{python_sitelib} which should have been
> written as %{python2_sitelib} and same for %{__python} to %{__python2}

Thanks for the tip, I missed this change in the guidelines. I was going to target EPEL6 for this package so I will change it to use %{__python2} with some suitable conditionals when I import the package.

And thanks for the review :-)

Comment 3 Dan Callaghan 2014-01-02 22:42:05 UTC
New Package SCM Request
=======================
Package Name: python-ofxparse
Short Description: Python library for working with the Open Financial Exchange file format
Owners: dcallagh
Branches: f19 f20 el6
InitialCC:

Comment 4 Gwyn Ciesla 2014-01-03 12:42:11 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-01-07 00:58:30 UTC
python-ofxparse-0.14-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-ofxparse-0.14-2.fc20

Comment 6 Fedora Update System 2014-01-07 00:59:16 UTC
python-ofxparse-0.14-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-ofxparse-0.14-2.fc19

Comment 7 Dan Callaghan 2014-01-07 01:00:20 UTC
EPEL6 build is coming soon, it needs patches to fix a build failure but I'm going to wait for upstream's opinion first:

https://github.com/jseutter/ofxparse/pull/65

Comment 8 Fedora Update System 2014-01-08 07:57:39 UTC
python-ofxparse-0.14-2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 9 Fedora Update System 2014-01-17 05:46:53 UTC
python-ofxparse-0.14-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 10 Fedora Update System 2014-01-17 05:52:21 UTC
python-ofxparse-0.14-2.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.