Bug 1046917
| Summary: | [PATCH] generic_should: fix self.flags uninitialized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> | ||||
| Component: | fedora-review | Assignee: | Stanislav Ochotnicky <sochotni> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 20 | CC: | ignatenko, leamas.alec, pingou, sochotni, zbyszek | ||||
| Target Milestone: | --- | Keywords: | EasyFix, Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-12-27 14:57:30 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 842288 [details]
0001-generic_should-fix-self.flags-uninitialized.patch
Patch for fix.
Hm, I don't know the code at all, but overwriting self.flags, which was already initialized before, with a newly created object seems wrong. Thanks for patch! Will look into this over the weekend. *** This bug has been marked as a duplicate of bug 1044580 *** |
$ $ find -maxdepth 1 -type f ./se-sandbox-runner-1.3.5-1.fc20.src.rpm ./se-sandbox-runner.spec $ fedora-review -n se-sandbox-runner [snipped] ERROR: Exception down the road...(logs in /home/brain/.cache/fedora-review.log) $ cat /home/brain/.cache/fedora-review.log [snipped] Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 232, in run self._do_run(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 222, in _do_run self._do_report(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 96, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 105, in _run_checks self.checks = Checks(spec, srpm) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 268, in __init__ _ChecksLoader.__init__(self) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 166, in __init__ self._load_checks() File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 204, in _load_checks tests = registry.register(plugin) File "/usr/lib/python2.7/site-packages/FedoraReview/registry.py", line 130, in register obj = (c[1])(self.checks) File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_should.py", line 80, in __init__ if self.flags['EPEL5']: KeyError: 'EPEL5'