Bug 1047610
| Summary: | Review Request: php-phpseclib-crypt-twofish - Pure-PHP implementation of Twofish | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-01-14 20:06:05 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1047596 | ||||||||
| Bug Blocks: | 1047611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Williamson
2014-01-01 03:29:26 UTC
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-twofish/php-phpseclib-crypt-twofish.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-twofish/php-phpseclib-crypt-twofish-0.3.5-2.fc21.src.rpm Created attachment 846732 [details]
phpci.log
phpcompatinfo version 2.26.0.
Created attachment 846734 [details]
review.txt
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047610
[!]: Requires correct, justified where necessary.
From package.xml, option so package choice
php-mcrypt
From code, used in Crypt_Twofish::setPawword()
php-pear(phpseclib.sourceforge.net/Crypt_Hash)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
=> License text is included in the single source header
[x]: Package does not own files or directories owned by other packages.
Ok, but if you add require on Crypt_Hash, you have to drop the ownership of
/usr/share/pear/Crypt
Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-twofish/php-phpseclib-crypt-twofish.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-twofish/php-phpseclib-crypt-twofish-0.3.5-3.fc21.src.rpm [x]: Requires correct, justified where necessary. [x]: Package does not own files or directories owned by other packages. == APPROVED == New Package SCM Request ======================= Package Name: php-phpseclib-crypt-twofish Short Description: Pure PHP implementation of Twofish Owners: adamwill Branches: f20 el6 InitialCC: Git done (by process-git-requests). Building for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6405158 Package Change Request ====================== Package Name: php-phpseclib-crypt-twofish New Branches: f19 epel7 No owners specified. Package Change Request ====================== Package Name: php-phpseclib-crypt-twofish New Branches: f19 epel7 Owners: adamwill Git done (by process-git-requests). |