Bug 1047610 - Review Request: php-phpseclib-crypt-twofish - Pure-PHP implementation of Twofish
Summary: Review Request: php-phpseclib-crypt-twofish - Pure-PHP implementation of Twofish
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1047596
Blocks: 1047611
TreeView+ depends on / blocked
 
Reported: 2014-01-01 03:29 UTC by Adam Williamson
Modified: 2014-02-25 18:51 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-01-14 20:06:05 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (8.42 KB, text/plain)
2014-01-07 15:22 UTC, Remi Collet
no flags Details
review.txt (7.78 KB, text/plain)
2014-01-07 15:23 UTC, Remi Collet
no flags Details

Description Adam Williamson 2014-01-01 03:29:26 UTC
Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-Twofish/php-phpseclib-Crypt-Twofish.spec
SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-Crypt-Twofish/php-phpseclib-Crypt-Twofish-0.3.5-1.fc21.src.rpm
Description: Uses mcrypt, if available, and an internal implementation, otherwise.
Fedora Account System Username: adamwill

Comment 2 Remi Collet 2014-01-07 15:22:27 UTC
Created attachment 846732 [details]
phpci.log

phpcompatinfo version 2.26.0.

Comment 3 Remi Collet 2014-01-07 15:23:04 UTC
Created attachment 846734 [details]
review.txt

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1047610

Comment 4 Remi Collet 2014-01-07 15:23:28 UTC
[!]: Requires correct, justified where necessary.
  From package.xml, option so package choice
    php-mcrypt
  From code, used in Crypt_Twofish::setPawword()
    php-pear(phpseclib.sourceforge.net/Crypt_Hash)

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
  => License text is included in the single source header

[x]: Package does not own files or directories owned by other packages.
  Ok, but if you add require on Crypt_Hash, you have to drop the ownership of
  /usr/share/pear/Crypt

Comment 6 Remi Collet 2014-01-10 06:39:16 UTC
[x]: Requires correct, justified where necessary.
[x]: Package does not own files or directories owned by other packages.

== APPROVED ==

Comment 7 Adam Williamson 2014-01-10 20:06:35 UTC
New Package SCM Request
=======================
Package Name: php-phpseclib-crypt-twofish
Short Description: Pure PHP implementation of Twofish
Owners: adamwill
Branches: f20 el6
InitialCC:

Comment 8 Gwyn Ciesla 2014-01-10 20:23:09 UTC
Git done (by process-git-requests).

Comment 9 Adam Williamson 2014-01-14 20:06:05 UTC
Building for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6405158

Comment 10 Adam Williamson 2014-02-24 03:27:19 UTC
Package Change Request
======================
Package Name: php-phpseclib-crypt-twofish
New Branches: f19 epel7

Comment 11 Gwyn Ciesla 2014-02-24 13:30:21 UTC
No owners specified.

Comment 12 Adam Williamson 2014-02-25 18:26:30 UTC
Package Change Request
======================
Package Name: php-phpseclib-crypt-twofish
New Branches: f19 epel7
Owners: adamwill

Comment 13 Gwyn Ciesla 2014-02-25 18:51:06 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.