Bug 1047914

Summary:	Fix rounding error in clipper.cpp
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	polyclipping	Assignee:	Miro Hrončok <mhroncok>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	mhroncok, volker27
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-03-24 09:57:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miro Hrončok 2014-01-02 14:58:46 UTC

Hi,
could you please include this patch in polyclipping package?

https://github.com/alexrj/Slic3r/commit/067cc1a74a653abfe043462753ac503d0211c177

It is already included in the upstream code (but the commit history there is a mess).

It fixes a problem in slic3r.

It also won't need any depending packages to rebuild, as it doesn't change the ABI.

Thanks

Comment 1 Miro Hrončok 2014-01-03 14:42:13 UTC

Or just give me an approval to do it :)

Comment 2 Volker Fröhlich 2014-01-03 14:50:58 UTC

I'll happily let you co-maintain it, if you apply!

I looked into the patch yesterday and it's not a straight patch. The relevant section in Rawhide looks pretty different.

Comment 3 Miro Hrončok 2014-01-03 15:15:30 UTC

There's only an extra line break there.

Will do it.

Comment 4 Miro Hrončok 2014-01-03 15:28:47 UTC

So applying the patch was not the only thing that keeps slic3r tests failing.

Apparently slic3r uses clipper 5.1.5 and that might be the issue, I will look deeper to the test and examine what the problem is.

Comment 5 Volker Fröhlich 2014-03-23 22:50:04 UTC

Are there news on this issue?

Comment 6 Miro Hrončok 2014-03-24 09:57:38 UTC

The rounding error is fixed, the rest is not at my agenda right now. Thanks