Bug 1047914 - Fix rounding error in clipper.cpp
Summary: Fix rounding error in clipper.cpp
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: polyclipping
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-02 14:58 UTC by Miro Hrončok
Modified: 2014-03-24 09:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-24 09:57:38 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2014-01-02 14:58:46 UTC 
Hi,
could you please include this patch in polyclipping package?

https://github.com/alexrj/Slic3r/commit/067cc1a74a653abfe043462753ac503d0211c177

It is already included in the upstream code (but the commit history there is a mess).

It fixes a problem in slic3r.

It also won't need any depending packages to rebuild, as it doesn't change the ABI.

Thanks
Comment 1 Miro Hrončok 2014-01-03 14:42:13 UTC 
Or just give me an approval to do it :)
Comment 2 Volker Fröhlich 2014-01-03 14:50:58 UTC 
I'll happily let you co-maintain it, if you apply!

I looked into the patch yesterday and it's not a straight patch. The relevant section in Rawhide looks pretty different.
Comment 3 Miro Hrončok 2014-01-03 15:15:30 UTC 
There's only an extra line break there.

Will do it.
Comment 4 Miro Hrončok 2014-01-03 15:28:47 UTC 
So applying the patch was not the only thing that keeps slic3r tests failing.

Apparently slic3r uses clipper 5.1.5 and that might be the issue, I will look deeper to the test and examine what the problem is.
Comment 5 Volker Fröhlich 2014-03-23 22:50:04 UTC 
Are there news on this issue?
Comment 6 Miro Hrončok 2014-03-24 09:57:38 UTC 
The rounding error is fixed, the rest is not at my agenda right now. Thanks
Note You need to log in before you can comment on or make changes to this bug.