Bug 1050953
| Summary: | Review Request: octave-parallel - Parallel execution package for cluster computers for Octave | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Sailer <fedora> |
| Component: | Package Review | Assignee: | Orion Poplawski <orion> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | orion, package-review |
| Target Milestone: | --- | Flags: | orion:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | octave-parallel-2.1.1-3.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-19 04:03:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1050900 | ||
|
Description
Thomas Sailer
2014-01-09 12:22:39 UTC
- Let's drop the octave-forge Obsoletes - that was last shipped in F15/EL5.
- Drop rm -rf %{buildroot} from %install
- There is no .svnignore file
- Why are you removing the doc directory?
- No need for %defattr()
Thank you Orion for taking the review! Here's the update: http://sailer.fedorapeople.org/octave-parallel.spec http://sailer.fedorapeople.org/octave-parallel-2.1.1-2.fc20.src.rpm (In reply to Orion Poplawski from comment #1) > - Why are you removing the doc directory? Because the same files are added using %doc later, thus end up in /usr/share/doc/octave-parallel-*. I can change this and leave the README* files in the original place, if you want. Okay, removing doc seems okay in this case. Be careful though in case docs are added in the future. Final item - I don't see the GFDL license anywhere. Urgh, that's a copy&paste leftover, so I removed GFDL. http://sailer.fedorapeople.org/octave-parallel.spec http://sailer.fedorapeople.org/octave-parallel-2.1.1-3.fc20.src.rpm Great, approved. Thank you! New Package SCM Request ======================= Package Name: octave-parallel Short Description: Parallel execution package for cluster computers for Octave Owners: sailer Branches: f19 f20 InitialCC: Git done (by process-git-requests). octave-parallel-2.1.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/octave-parallel-2.1.1-3.fc19 octave-parallel-2.1.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/octave-parallel-2.1.1-3.fc20 octave-parallel-2.1.1-3.fc19 has been pushed to the Fedora 19 testing repository. octave-parallel-2.1.1-3.fc19 has been pushed to the Fedora 19 stable repository. octave-parallel-2.1.1-3.fc20 has been pushed to the Fedora 20 stable repository. |