Spec URL: http://sailer.fedorapeople.org/octave-parallel.spec SRPM URL: http://sailer.fedorapeople.org/octave-parallel-2.1.1-1.fc20.src.rpm Description: Parallel execution package for cluster computers for Octave scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6378405 rpmlint octave-parallel.spec /home/sailer/rpmbuild/SRPMS/octave-parallel-2.1.1-1.fc20.src.rpm /home/sailer/rpmbuild/RPMS/x86_64/octave-parallel-2.1.1-1.fc20.x86_64.rpm /home/sailer/rpmbuild/RPMS/x86_64/octave-parallel-debuginfo-2.1.1-1.fc20.x86_64.rpm octave-parallel.x86_64: W: obsolete-not-provided octave-forge octave-parallel.x86_64: W: dangerous-command-in-%preun rm octave-parallel-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 0775L octave-parallel-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/parallel-2.1.1 0775L 3 packages and 1 specfiles checked; 2 errors, 2 warnings. These errors and warnings cannot be influenced in this .spec file, so they can be ignored.
- Let's drop the octave-forge Obsoletes - that was last shipped in F15/EL5. - Drop rm -rf %{buildroot} from %install - There is no .svnignore file - Why are you removing the doc directory? - No need for %defattr()
Thank you Orion for taking the review! Here's the update: http://sailer.fedorapeople.org/octave-parallel.spec http://sailer.fedorapeople.org/octave-parallel-2.1.1-2.fc20.src.rpm (In reply to Orion Poplawski from comment #1) > - Why are you removing the doc directory? Because the same files are added using %doc later, thus end up in /usr/share/doc/octave-parallel-*. I can change this and leave the README* files in the original place, if you want.
Okay, removing doc seems okay in this case. Be careful though in case docs are added in the future. Final item - I don't see the GFDL license anywhere.
Urgh, that's a copy&paste leftover, so I removed GFDL. http://sailer.fedorapeople.org/octave-parallel.spec http://sailer.fedorapeople.org/octave-parallel-2.1.1-3.fc20.src.rpm
Great, approved.
Thank you! New Package SCM Request ======================= Package Name: octave-parallel Short Description: Parallel execution package for cluster computers for Octave Owners: sailer Branches: f19 f20 InitialCC:
Git done (by process-git-requests).
octave-parallel-2.1.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/octave-parallel-2.1.1-3.fc19
octave-parallel-2.1.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/octave-parallel-2.1.1-3.fc20
octave-parallel-2.1.1-3.fc19 has been pushed to the Fedora 19 testing repository.
octave-parallel-2.1.1-3.fc19 has been pushed to the Fedora 19 stable repository.
octave-parallel-2.1.1-3.fc20 has been pushed to the Fedora 20 stable repository.