Bug 1051492

Description of problem:
Not sure if current situation is the best. When SMTP does not work (iptables -I OUTPUT -d $smtp_server -j REJECT) the mail is obviously staying somewhere in queue, and after SMTP is available again (remote iptables rules), there's no line about resending.

2014-01-10 13:25:47,576 DEBUG [org.ovirt.engine.core.notifier.utils.sender.mail.EventSenderMailImpl] Send email to [jbelka]
 subject:
 [Alert Notification. (testovic.rhev.lab.eng.brq.redhat.com), [Host dell-r210ii-13 was switched to Maintenance mode by admin@internal.]]
 body:
 [Time:2014-01-10 13:25:45.67
Message:Host dell-r210ii-13 was switched to Maintenance mode by admin@internal.
Severity:0
User Name: admin@internal
Host Name: dell-r210ii-13
]
2014-01-10 13:25:48,723 ERROR [org.ovirt.engine.core.notifier.utils.sender.mail.JavaMailSender] Failed to send message  to jbelka with subject Alert Notification. 
(testovic.rhev.lab.eng.brq.redhat.com), [Host dell-r210ii-13 was switched to Maintenance mode by admin@internal.] due to to error: Could not connect to SMTP host: smtp.corp.r
edhat.com, port: 25
javax.mail.MessagingException: Could not connect to SMTP host: smtp.corp.redhat.com, port: 25;
  nested exception is:
        java.net.ConnectException: Connection refused
        at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:1972)
        at com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:642)
        at javax.mail.Service.connect(Service.java:295)
        at javax.mail.Service.connect(Service.java:176)
        at javax.mail.Service.connect(Service.java:125)
        at javax.mail.Transport.send0(Transport.java:194)
        at javax.mail.Transport.send(Transport.java:124)
        at org.ovirt.engine.core.notifier.utils.sender.mail.JavaMailSender.send(JavaMailSender.java:152)
        at org.ovirt.engine.core.notifier.utils.sender.mail.EventSenderMailImpl.send(EventSenderMailImpl.java:79)
        at org.ovirt.engine.core.notifier.NotificationService.processEvents(NotificationService.java:263)
        at org.ovirt.engine.core.notifier.NotificationService.run(NotificationService.java:120)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:744)
Caused by: java.net.ConnectException: Connection refused
        at java.net.PlainSocketImpl.socketConnect(Native Method)
        at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
        at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
        at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182)
        at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
        at java.net.Socket.connect(Socket.java:579)
        at java.net.Socket.connect(Socket.java:528)
        at com.sun.mail.util.SocketFetcher.createSocket(SocketFetcher.java:319)
        at com.sun.mail.util.SocketFetcher.getSocket(SocketFetcher.java:233)
        at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:1938)
        ... 17 more

Version-Release number of selected component (if applicable):
is31 / rhevm-tools-3.3.0-0.44.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. block access to SMTP server
2. generate event
3. unblock access to SMTP server

Actual results:
error and then no info about resending

Expected results:
error, then a line about actual resending of message

Additional info:
Well I think it should be improved completely:

1. change from 'Send email' to 'Submitting for send'

2014-01-10 13:25:47,576 DEBUG [org.ovirt.engine.core.notifier.utils.sender.mail.EventSenderMailImpl] Send email to [jbelka]
 subject:
 [Alert Notification. (testovic.rhev.lab.eng.brq.redhat.com), [Host dell-r210ii-13 was switched to Maintenance mode by admin@internal.]]
 body:
 [Time:2014-01-10 13:25:45.67
Message:Host dell-r210ii-13 was switched to Maintenance mode by admin@internal.
Severity:0
User Name: admin@internal
Host Name: dell-r210ii-13
]

  as in this time it is not clear if actual sending would work.

2. if ERROR, then some msg about keeping the mail for later resend
3. if OK, then logged as successfully sent