Bug 1053733

Summary: Faulty storage allocation checks when merging a snapshot
Product: [Retired] oVirt Reporter: Allon Mureinik <amureini>
Component: ovirt-engine-coreAssignee: Vered Volansky <vered>
Status: CLOSED CURRENTRELEASE QA Contact: Ori Gofen <ogofen>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4CC: acanan, amureini, bugs, dfediuck, eedri, gklein, lpeer, nlevinki, rbalakri, Rhev-m-bugs, scohen, srevivo, vered, yeylon, ylavi
Target Milestone: ---Keywords: Reopened
Target Release: 3.5.2   
Hardware: Unspecified   
OS: All   
Whiteboard: storage
Fixed In Version: ovirt-3.5.1_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 960934
: 1053740 1053746 1053752 1178010 (view as bug list) Environment:
Last Closed: 2015-04-29 06:15:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1117231, 1178010, 1193058, 1196662, 1197441    

Description Allon Mureinik 2014-01-15 17:05:04 UTC 
+++ This bug was initially created as a clone of Bug #960934 +++

When merging a snapshot disk, we have a transient situation where the data of the merged snapshot exists twice - in the source and target.
We must make sure we have this space for a successful merge:

      | File Domain                             | Block Domain
 -----|-----------------------------------------|-------------
 qcow | preallocated : 1.1 * disk capacity      |1.1 * min(used ,capacity) 
      | sparse: 1.1 * min(used ,capacity)       |
 -----|-----------------------------------------|-------------
 raw  | preallocated: disk capacity             |disk capacity
      | sparse: min(used,capacity)
Comment 1 Vered Volansky 2014-10-01 07:14:31 UTC 
The related commands to the above scenario are RemoveSnapshotCommand and RemoveDiskSnapshotsCommand.

Verify in two ways:
1. Remove a snapshot from vm tab, snapshots subtab.
2. Remove a disk snapshot from the storage tab, snapshots subtab.

Say we have B + S1 + S2, all 10G.
SD should have extra available space for 20G (the maximum size merge of the two snapshots). Domain with less than 20G free space should fail and 20G+ should succeed.
Comment 2 Sandro Bonazzola 2015-01-15 14:14:27 UTC 
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA
Comment 3 Aharon Canan 2015-01-19 07:12:34 UTC 
verified downstream already
Comment 4 Eyal Edri 2015-02-26 12:31:24 UTC 
this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.
Comment 5 Ori Gofen 2015-03-19 09:40:15 UTC 
verified on vt14
Comment 6 Eyal Edri 2015-04-29 06:15:35 UTC 
ovirt 3.5.2 was GA'd. closing current release.