Bug 1053746 - Faulty storage allocation checks when importing a VM
Summary: Faulty storage allocation checks when importing a VM
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.4
Hardware: Unspecified
OS: All
medium
high
Target Milestone: ---
: 3.5.0
Assignee: Vered Volansky
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard: storage
: 803724 (view as bug list)
Depends On:
Blocks: 960934 1136721 1136734
TreeView+ depends on / blocked
 
Reported: 2014-01-15 17:24 UTC by Allon Mureinik
Modified: 2016-02-10 17:58 UTC (History)
16 users (show)

Fixed In Version: ovirt-3.5.0_rc3
Doc Type: Bug Fix
Doc Text:
Clone Of: 1053733
: 1053747 1053750 1136719 1136721 (view as bug list)
Environment:
Last Closed: 2014-10-17 12:35:34 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 32258 0 master MERGED core: ImportVmCommand storage allocation checks Never
oVirt gerrit 32898 0 ovirt-engine-3.5 MERGED core: ImportVmCommand storage allocation checks Never

Description Allon Mureinik 2014-01-15 17:24:26 UTC
+++ This bug was initially created as a clone of Bug #1053733 +++

+++ This bug was initially created as a clone of Bug #960934 +++

The storage requirements for each disk in the imported VM:

      | File Domain                             | Block Domain
 -----|-----------------------------------------|-------------
 qcow | preallocated : 1.1 * disk capacity      |1.1 * min(used ,capacity) 
      | sparse: 1.1 * min(used ,capacity)       |
 -----|-----------------------------------------|-------------
 raw  | preallocated: disk capacity             |disk capacity
      | sparse: min(used,capacity)

Comment 1 Allon Mureinik 2014-08-10 10:48:18 UTC
*** Bug 803724 has been marked as a duplicate of this bug. ***

Comment 2 Vered Volansky 2014-09-07 16:53:52 UTC
Importing disks with snapshots can be done either with the snapshots as is, or with the snapshots collapsed. For the latter the table from comment#0 applies.
For the first case the following table applies:

      | File Domain                             | Block Domain
 -----|-----------------------------------------|----------------
 qcow | 1.1 * used space                        |1.1 * used space
 -----|-----------------------------------------|----------------
 raw  | preallocated: disk capacity             |disk capacity
      | sparse: used space                      |

When verifying this bug both cases should be verified, positive and negative tests: Verify against a storage domain with and without enough space - just about the needed/excess space for the disks. Verify it succeeds when there's enough space and fails on CDA when it doesn't.

Threshold should also be verified on this bug.

Comment 3 Sandro Bonazzola 2014-10-17 12:35:34 UTC
oVirt 3.5 has been released and should include the fix for this issue.


Note You need to log in before you can comment on or make changes to this bug.