Bug 1054086

Summary: Change Vendor tag
Product: [Community] Copr Reporter: Miroslav Suchý <msuchy>
Component: backendAssignee: Miroslav Suchý <msuchy>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: ignatenko
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: copr-1.25-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-06 08:32:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1028438    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch against master branch, but blocks by RHBZ #1028438
none
[PATCH v2] proposed, but blocks by RHBZ #1028438
none
[PATCH] another way. add tag, when modify buildroot none

Description Miroslav Suchý 2014-01-16 08:30:23 UTC 
We need to change Vendor tag, so it is clear that package comes from Copr.

See https://fedorahosted.org/fesco/ticket/1218#comment:19 for background.

I will do some testing and will report here what I would like to implement.

Suggestion from FESCO meeting:

[19:46] <notting> t8m: +1, default to "COPR: <account name>"?
[19:47] <mattdm> proposal "Vendor: Fedora Project COPRs / coprname"
[19:47] <sgallagh> mattdm: Vendor: Fedora Project COPR <coprname>
Comment 1 Igor Gnatenko 2014-01-21 09:08:43 UTC 
Created attachment 853051 [details]
Proposed patch against master branch, but blocks by RHBZ #1028438

We have 2 way:

*
 -> Copy original mock config
 -> Parse it and add
    config_opts['macros']['%vendor'] = 'Fedora Project COPR <coprname>'
    For sure escaping vendor and auto-gen coprname

*
 -> Implement Feature to mockchain ()
 -> Add to cmdline backend/mockremote.py:327
    -D "Vendor Fedora Project COPR <coprname>"


Second way preferred for me.

Miroslav, what do you think about first way ?
Comment 2 Igor Gnatenko 2014-01-21 09:14:06 UTC 
Created attachment 853053 [details]
[PATCH v2] proposed, but blocks by RHBZ #1028438

Oops. That patch wrong
Comment 3 Igor Gnatenko 2014-01-21 14:10:20 UTC 
Created attachment 853250 [details]
[PATCH] another way. add tag, when modify buildroot

This is another way ;)
Comment 4 Miroslav Suchý 2014-01-21 14:51:05 UTC 
I choosed different approach Igor :)

Commited as 3888ac9.

Vendor of packages in Copr will be:
 "Fedora Project COPR (%s/%s)" % (job.user_name, job.copr_name)
Comment 5 Igor Gnatenko 2014-01-21 14:54:44 UTC 
Or so. ;)