Bug 1054086 - Change Vendor tag
Summary: Change Vendor tag
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Copr
Classification: Community
Component: backend
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact:
URL:
Whiteboard:
Depends On: 1028438
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-16 08:30 UTC by Miroslav Suchý
Modified: 2014-02-06 08:32 UTC (History)
1 user (show)

Fixed In Version: copr-1.25-1
Clone Of:
Environment:
Last Closed: 2014-02-06 08:32:05 UTC
Embargoed:


Attachments (Terms of Use)
Proposed patch against master branch, but blocks by RHBZ #1028438 (949 bytes, patch)
2014-01-21 09:08 UTC, Igor Gnatenko
no flags Details | Diff
[PATCH v2] proposed, but blocks by RHBZ #1028438 (958 bytes, patch)
2014-01-21 09:14 UTC, Igor Gnatenko
no flags Details | Diff
[PATCH] another way. add tag, when modify buildroot (3.03 KB, patch)
2014-01-21 14:10 UTC, Igor Gnatenko
no flags Details | Diff

Description Miroslav Suchý 2014-01-16 08:30:23 UTC
We need to change Vendor tag, so it is clear that package comes from Copr.

See https://fedorahosted.org/fesco/ticket/1218#comment:19 for background.

I will do some testing and will report here what I would like to implement.

Suggestion from FESCO meeting:

[19:46] <notting> t8m: +1, default to "COPR: <account name>"?
[19:47] <mattdm> proposal "Vendor: Fedora Project COPRs / coprname"
[19:47] <sgallagh> mattdm: Vendor: Fedora Project COPR <coprname>

Comment 1 Igor Gnatenko 2014-01-21 09:08:43 UTC
Created attachment 853051 [details]
Proposed patch against master branch, but blocks by RHBZ #1028438

We have 2 way:

*
 -> Copy original mock config
 -> Parse it and add
    config_opts['macros']['%vendor'] = 'Fedora Project COPR <coprname>'
    For sure escaping vendor and auto-gen coprname

*
 -> Implement Feature to mockchain ()
 -> Add to cmdline backend/mockremote.py:327
    -D "Vendor Fedora Project COPR <coprname>"


Second way preferred for me.

Miroslav, what do you think about first way ?

Comment 2 Igor Gnatenko 2014-01-21 09:14:06 UTC
Created attachment 853053 [details]
[PATCH v2] proposed, but blocks by RHBZ #1028438

Oops. That patch wrong

Comment 3 Igor Gnatenko 2014-01-21 14:10:20 UTC
Created attachment 853250 [details]
[PATCH] another way. add tag, when modify buildroot

This is another way ;)

Comment 4 Miroslav Suchý 2014-01-21 14:51:05 UTC
I choosed different approach Igor :)

Commited as 3888ac9.

Vendor of packages in Copr will be:
 "Fedora Project COPR (%s/%s)" % (job.user_name, job.copr_name)

Comment 5 Igor Gnatenko 2014-01-21 14:54:44 UTC
Or so. ;)


Note You need to log in before you can comment on or make changes to this bug.