Bug 1054867
| Summary: | Review Request: perl-Lingua-EN-Sentence - Module for splitting text into sentences | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade, xavier |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Lingua-EN-Sentence-0.25-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-31 04:24:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ralf Corsepius
2014-01-17 16:03:29 UTC
will take this for review Review: + Package build successfully in mock rawhide - rpmlint on generated rpms gave output perl-Lingua-EN-Sentence.noarch: W: file-not-utf8 /usr/share/doc/perl-Lingua-EN-Sentence/Changes 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + Source verified with upstream as upstream source => f886e3e9e2ddab299f80fd9f252eb48930b0bf4e1cbd1e85193d8565727e171d srpm source => f886e3e9e2ddab299f80fd9f252eb48930b0bf4e1cbd1e85193d8565727e171d + License is valid and included as header in source file. + make test gave All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.02 cusr 0.00 csys = 0.05 CPU) + Package perl-Lingua-EN-Sentence-0.25-1.fc21.noarch => Provides: perl(Lingua::EN::Sentence) = 0.25 perl-Lingua-EN-Sentence = 0.25-1.fc21 Requires: perl >= 0:5.005_03 perl(Carp) perl(Exporter) perl(POSIX) perl(locale) perl(strict) perl(vars) Suggestions: 1) Fix the rpmlint warning of file-not-utf8 before importing this package in Fedora. 2) Group tag is optional. You may want to remove it from spec. APPROVED. Thanks for the review, Parag. (In reply to Parag AN(पराग) from comment #2) > 1) Fix the rpmlint warning of file-not-utf8 before importing this package in > Fedora. Will do so. New Package SCM Request ======================= Package Name: perl-Lingua-EN-Sentence Short Description: Module for splitting text into sentences Owners: corsepiu Branches: f20 f19 InitialCC: perl-sig Git done (by process-git-requests). perl-Lingua-EN-Sentence-0.25-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Lingua-EN-Sentence-0.25-1.fc20 perl-Lingua-EN-Sentence-0.25-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Lingua-EN-Sentence-0.25-1.fc19 perl-Lingua-EN-Sentence-0.25-1.fc20 has been pushed to the Fedora 20 testing repository. perl-Lingua-EN-Sentence-0.25-1.fc19 has been pushed to the Fedora 19 stable repository. perl-Lingua-EN-Sentence-0.25-1.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: perl-Lingua-EN-Sentence New Branches: el6 epel7 Owners: xavierb InitialCC: perl-sig Ralf is fine with me taking care of the EL branches. Git done (by process-git-requests). |