Bug 1054867 - Review Request: perl-Lingua-EN-Sentence - Module for splitting text into sentences
Summary: Review Request: perl-Lingua-EN-Sentence - Module for splitting text into sen...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-17 16:03 UTC by Ralf Corsepius
Modified: 2014-04-22 13:00 UTC (History)
3 users (show)

Fixed In Version: perl-Lingua-EN-Sentence-0.25-1.fc20
Clone Of:
Environment:
Last Closed: 2014-01-31 04:24:43 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2014-01-17 16:03:29 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Lingua-EN-Sentence.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Lingua-EN-Sentence-0.25-1.fc21.src.rpm
Description:
The Lingua::EN::Sentence module contains the function get_sentences, which
splits text into its constituent sentences, based on a regular expression
and a list of abbreviations (built in and given).

Fedora Account System Username: corsepiu

Comment 1 Parag AN(पराग) 2014-01-19 06:57:45 UTC
will take this for review

Comment 2 Parag AN(पराग) 2014-01-20 04:21:12 UTC
Review:

+ Package build successfully in mock rawhide

- rpmlint on generated rpms gave output
perl-Lingua-EN-Sentence.noarch: W: file-not-utf8 /usr/share/doc/perl-Lingua-EN-Sentence/Changes
2 packages and 0 specfiles checked; 0 errors, 1 warnings.


+ Source verified with upstream as
upstream source => f886e3e9e2ddab299f80fd9f252eb48930b0bf4e1cbd1e85193d8565727e171d
srpm source => f886e3e9e2ddab299f80fd9f252eb48930b0bf4e1cbd1e85193d8565727e171d

+ License is valid and included as header in source file.

+ make test gave 
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.02 cusr  0.00 csys =  0.05 CPU)

+ Package perl-Lingua-EN-Sentence-0.25-1.fc21.noarch =>
Provides: perl(Lingua::EN::Sentence) = 0.25 perl-Lingua-EN-Sentence = 0.25-1.fc21
Requires: perl >= 0:5.005_03 perl(Carp) perl(Exporter) perl(POSIX) perl(locale) perl(strict) perl(vars)



Suggestions:
1) Fix the rpmlint warning of file-not-utf8 before importing this package in Fedora.


2) Group tag is optional. You may want to remove it from spec.
APPROVED.

Comment 3 Ralf Corsepius 2014-01-20 05:57:15 UTC
Thanks for the review, Parag.

(In reply to Parag AN(पराग) from comment #2)
> 1) Fix the rpmlint warning of file-not-utf8 before importing this package in
> Fedora.
Will do so.


New Package SCM Request
=======================
Package Name: perl-Lingua-EN-Sentence
Short Description: Module for splitting text into sentences
Owners: corsepiu
Branches: f20 f19
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-01-21 14:08:59 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-01-21 16:16:56 UTC
perl-Lingua-EN-Sentence-0.25-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Lingua-EN-Sentence-0.25-1.fc20

Comment 6 Fedora Update System 2014-01-21 16:17:11 UTC
perl-Lingua-EN-Sentence-0.25-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Lingua-EN-Sentence-0.25-1.fc19

Comment 7 Fedora Update System 2014-01-22 23:04:33 UTC
perl-Lingua-EN-Sentence-0.25-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 8 Fedora Update System 2014-01-31 04:24:43 UTC
perl-Lingua-EN-Sentence-0.25-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 9 Fedora Update System 2014-01-31 04:27:06 UTC
perl-Lingua-EN-Sentence-0.25-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 10 Xavier Bachelot 2014-04-22 11:17:54 UTC
Package Change Request
======================
Package Name: perl-Lingua-EN-Sentence
New Branches: el6 epel7
Owners: xavierb
InitialCC: perl-sig


Ralf is fine with me taking care of the EL branches.

Comment 11 Gwyn Ciesla 2014-04-22 13:00:20 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.