Bug 1057558

Summary:	The customized haproxy_ctld.rb will not take effect after git push unless you restart the haproxy cartridge manually
Product:	OpenShift Online	Reporter:	Meng Bo <bmeng>
Component:	Image	Assignee:	Brenton Leanhardt <bleanhar>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	2.x	CC:	bleanhar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-26 19:10:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1051190

Description Meng Bo 2014-01-24 10:55:51 UTC

Description of problem:
Create customized haproxy_ctld.rb and git repo .openshift/action_hooks with executable permission. Git push the change to remote.

Since the haproxy cartridge will only reload the configuration but not restart, then the user added haproxy_ctld.rb will never be used unless restart the haproxy manually.

Version-Release number of selected component (if applicable):
devenv_4270

How reproducible:
always

Steps to Reproduce:
1. Create scalable app
2. Add haproxy_ctld.rb to .openshift/action_hooks/ with x permission
3. Git push the change

Actual results:
The customized haproxy_ctld.rb will not take effect till the haproxy restart.

Expected results:
Should trigger the haproxy to restart if the customized haproxy_ctld.rb added.

Additional info:

Comment 1 Brenton Leanhardt 2014-01-31 20:10:12 UTC

Proposed patch: https://github.com/openshift/origin-server/pull/4642

Comment 2 openshift-github-bot 2014-02-03 21:49:38 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/4c8782219b93676ae32edae9f82f94adc30399a8
Bug 1057558 - reload the haproxy_ctld.rb action hook on git push

Comment 3 Meng Bo 2014-02-08 07:05:11 UTC

Checked on devenv_4348, after add the action_hook, the haproxy_ctld will reload the new config, and take effect after git push.

Client output found in the git push log:

remote: HAProxy already running
remote: Action hook haproxy_ctld.rb detected
remote: Action hook haproxy_ctld.rb restarted
remote: HAProxy instance is started


Without the action_hook added, haproxy_ctld will not restart.