Description of problem: Create customized haproxy_ctld.rb and git repo .openshift/action_hooks with executable permission. Git push the change to remote. Since the haproxy cartridge will only reload the configuration but not restart, then the user added haproxy_ctld.rb will never be used unless restart the haproxy manually. Version-Release number of selected component (if applicable): devenv_4270 How reproducible: always Steps to Reproduce: 1. Create scalable app 2. Add haproxy_ctld.rb to .openshift/action_hooks/ with x permission 3. Git push the change Actual results: The customized haproxy_ctld.rb will not take effect till the haproxy restart. Expected results: Should trigger the haproxy to restart if the customized haproxy_ctld.rb added. Additional info:
Proposed patch: https://github.com/openshift/origin-server/pull/4642
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/4c8782219b93676ae32edae9f82f94adc30399a8 Bug 1057558 - reload the haproxy_ctld.rb action hook on git push
Checked on devenv_4348, after add the action_hook, the haproxy_ctld will reload the new config, and take effect after git push. Client output found in the git push log: remote: HAProxy already running remote: Action hook haproxy_ctld.rb detected remote: Action hook haproxy_ctld.rb restarted remote: HAProxy instance is started Without the action_hook added, haproxy_ctld will not restart.