Bug 1057938

Summary:	Errors when setting CONFIG_NEUTRON_OVS_TUNNEL_IF to a VLAN interface
Product:	[Community] RDO	Reporter:	Lars Kellogg-Stedman <lars>
Component:	openstack-packstack	Assignee:	Gaël Chamoulaud <gchamoul>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ofer Blaut <oblaut>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	aortega, derekh, gchamoul, mmagr, oblaut, yeylon
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-packstack-2014.1.1-0.20.dev1149.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1059417 (view as bug list)		Environment:
Last Closed:	2016-03-30 23:09:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1059417

Description Lars Kellogg-Stedman 2014-01-26 04:12:38 UTC

As reported on ask.openstack.org:

  https://ask.openstack.org/en/question/10810/in-ethernet-device-name-causing-packstack-parse-error/

Setting CONFIG_NEUTRON_OVS_TUNNEL_IF to a VLAN defice (such as "eth0.1200") will result in packstack generating a manifest that attempts to reference `$ipaddress_eth0.1200`, which is an invalid variable/fact name.

Facter converts the `.` in the interface name to `_`, so the corresponding fact is `ipaddress_eth0_1200`.  Either packstack or the Puppet modules should take care of performing the appropriate transliteration.

Comment 1 Lars Kellogg-Stedman 2014-01-26 04:23:08 UTC

The same problem affects foreman users.

Comment 2 Martin Magr 2014-01-27 14:19:20 UTC

This cannot be fixed on module level. Both packstack and foreman have to have valid manifests.

Comment 3 Lars Kellogg-Stedman 2014-01-27 15:36:08 UTC

Martin,

I agree with second part of comment #2, but I'm not sure what you mean by "this cannot be fixed on the module level".

Comment 4 Lars Kellogg-Stedman 2014-01-29 16:10:03 UTC

This same problem also affects the Swift templates.  From jjozwiak:

> When deploying Swift storage the 'swift_local_interface' was similar
> where it needed to be em2_102.

Comment 5 Lars Kellogg-Stedman 2014-01-29 19:37:17 UTC

Proposed fix for astapor in https://github.com/redhat-openstack/astapor/pull/109.

Comment 6 Lars Kellogg-Stedman 2014-01-29 19:57:55 UTC

Proposed fix for packstack in https://github.com/stackforge/packstack/pull/10.

Comment 7 Lars Kellogg-Stedman 2014-02-03 15:41:49 UTC

Updated fix at https://github.com/stackforge/packstack/pull/11 also handles "-" in interface names.

Comment 8 Martin Magr 2014-02-10 10:48:47 UTC

Lars thanks for a patch! But could you please submit the patch to Gerrit? We don't accept pull requests. Thanks in advance.

Comment 9 Martin Magr 2014-02-10 10:49:14 UTC

For more info check https://wiki.openstack.org/wiki/Gerrit_Workflow

Comment 10 Lars Kellogg-Stedman 2014-02-10 14:45:59 UTC

I'm familiar with launchpad's Gerrit workflow, but I wasn't aware that was the primary site for the stackforge repositories.  Thanks.

Comment 11 Lars Kellogg-Stedman 2014-02-12 21:03:21 UTC

Fix proposed in https://review.openstack.org/#/c/73060/

Comment 12 Gaël Chamoulaud 2014-06-12 20:03:09 UTC

Proposed fix for packstack in https://review.openstack.org/#/c/99749/