Bug 1058014

Summary:	FTBFS
Product:	Red Hat Enterprise Linux 7	Reporter:	Zenon Panoussis <redhatbugs>
Component:	xfsdump	Assignee:	Eric Sandeen <esandeen>
Status:	CLOSED DUPLICATE	QA Contact:	Filesystem QE <fs-qe>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	branto
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-27 12:32:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zenon Panoussis 2014-01-26 13:10:56 UTC

rpmbuild -ba xfsdump.spec
...
checking uuid.h usability... no
checking uuid.h presence... no
checking for uuid.h... no
checking sys/uuid.h usability... no
checking sys/uuid.h presence... no
checking for sys/uuid.h... no
checking uuid/uuid.h usability... yes
checking uuid/uuid.h presence... yes
checking for uuid/uuid.h... yes
checking for uuid_compare... no
checking for uuid_compare in -luuid... yes
checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking for pthread_mutex_init in -lpthread... yes
checking ncurses.h usability... yes
checking ncurses.h presence... yes
checking for ncurses.h... yes
checking for initscr in -lncurses... yes
checking for bad glibc/ncurses header interaction... ok
checking xfs/xfs.h usability... no
checking xfs/xfs.h presence... no
checking for xfs/xfs.h... no

FATAL ERROR: cannot find a valid <xfs/xfs.h> header file.
Install or upgrade the XFS development package.
Alternatively, run "make install-dev" from the xfsprogs source.

This hapens both inside and outside of mock. In mock xfsprogs-devel is pulled in correctly and the headers exist where they should:

$ ls /var/lib/mock/el7-beta1-i686/root/usr/include/xfs/
handle.h  jdm.h  linux.h  platform_defs.h  platform_defs-i386.h  xfs_fs.h  xfs.h  xqm.h

And the rpm path macros are OK:

+ /usr/bin/cp -fv /usr/lib/rpm/redhat/config.sub ./config.sub
'/usr/lib/rpm/redhat/config.sub' -> './config.sub'
+ ./configure --build=i686-redhat-linux-gnu --host=i686-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info
configure: WARNING: unrecognized options: --disable-dependency-tracking

I can't figure out what is causing it.

Comment 2 Zenon Panoussis 2014-01-26 14:28:05 UTC

I found it. 

xfs/xfs.h says #include <xfs/xfs_types.h>, but there is no such file in /usr/include/xfs/. 

xfs_types.h is provided by xfsprogs-qa-devel. Solution:

--- xfsdump.spec.orig	2014-01-26 15:27:12.254000000 +0100
+++ xfsdump.spec	2014-01-26 15:27:22.872000000 +0100
@@ -10,7 +10,7 @@
 Source0: ftp://oss.sgi.com/projects/xfs/cmd_tars/%{name}-%{version}.tar.gz
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: libtool, gettext, gawk
-BuildRequires: xfsprogs-devel, libuuid-devel, libattr-devel ncurses-devel
+BuildRequires: xfsprogs-devel, xfsprogs-qa-devel, libuuid-devel, libattr-devel ncurses-devel
 Requires: xfsprogs >= 2.6.30, attr >= 2.0.0

Now it builds.

Comment 3 Boris Ranto 2014-01-27 12:32:36 UTC

Hi,

this was already fixed in a more recent xfsprogs release (we moved xfs/xfs_types.h to xfsprogs-devel rpm), see bz1024048 for details.

Marking as duplicate of the bz.

*** This bug has been marked as a duplicate of bug 1024048 ***

Comment 4 Eric Sandeen 2014-01-27 15:44:38 UTC

Right, should be fixed now; I don't know why this hasn't been included in the buildroots, I built & tagged it on Nov 15, and filed the errata on Dec 19.

Comment 5 Zenon Panoussis 2014-01-27 19:46:21 UTC

(In reply to Eric Sandeen from comment #4)
> Right, should be fixed now; I don't know why this hasn't been included in
> the buildroots

It might have, but fixes that come out of QA are not pushed to http://ftp.redhat.com/pub/redhat/rhel/beta/7/ , so we keep running into bugs that have already been fixed.

Comment 6 Eric Sandeen 2014-01-27 19:47:32 UTC

All I can do is fix the bugs, I can't control all the machinery.  ;)  (TBH I missed that you were an external filer).