Bug 1060520
Summary: | Review Request: qm-vamp-plugins - Vamp audio feature extraction plugin | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | František Dvořák <valtri> |
Component: | Package Review | Assignee: | Martin Milata <mmilata> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mmilata, package-review, valtri |
Target Milestone: | --- | Flags: | mmilata:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | qm-vamp-plugins-1.7-2.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-11-10 06:13:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1060519 | ||
Bug Blocks: |
Description
František Dvořák
2014-02-02 10:25:00 UTC
Only found one issue: [1] says that "Packages which explicitly need to link against the static version must BuildRequire: foo-static, so that the usage can be tracked.", however qm-vamp-plugins buildrequire qm-dsp-devel. I guess the spec should be more explicit about linking against static libraries and require qm-dsp-static instead. Otherwise looks good and when mixxx is run with VAMP_PATH=/usr/lib64/vamp/ the options "Tempo and Beat Tracker" appears in the list of beat analysers. I guess this means that the package functions as described:) [1] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Packaging_Static_Libraries_2 New version: Spec URL: http://scientific.zcu.cz/fedora/qm-vamp-plugins-1.7-2/qm-vamp-plugins.spec SRPM URL: http://scientific.zcu.cz/fedora/qm-vamp-plugins-1.7-2/qm-vamp-plugins-1.7-2.fc22.src.rpm * Sat Oct 25 2014 František Dvořák <valtri.cz> - 1.7-2 - Replace qm-dsp-devel for qm-dsp-static BR > > Otherwise looks good and when mixxx is run with VAMP_PATH=/usr/lib64/vamp/ > the options "Tempo and Beat Tracker" appears in the list of beat analysers. > I guess this means that the package functions as described:) > Wow, so mixxx doesn't even to be recompiled to see the plugin work. :-) I'm happy with the spec now, proposing ACCEPT. Thank you for the package! Are you planning to work with the mixxx maintainer to enable the plugins by default? Thanks for the reviews! There exists a bugreport for BPM analyzer in mixx: https://bugzilla.rpmfusion.org/show_bug.cgi?id=3019, so the work can continue there. New Package SCM Request ======================= Package Name: qm-vamp-plugins Short Description: Vamp audio feature extraction plugin Upstream URL: http://isophonics.net/QMVampPlugins Owners: valtri Branches: f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). qm-vamp-plugins-1.7-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qm-vamp-plugins-1.7-2.fc21 qm-vamp-plugins-1.7-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/qm-vamp-plugins-1.7-2.fc20 qm-vamp-plugins-1.7-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/qm-vamp-plugins-1.7-2.el7 qm-vamp-plugins-1.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/qm-vamp-plugins-1.7-2.el6 qm-vamp-plugins-1.7-2.fc21 has been pushed to the Fedora 21 testing repository. qm-vamp-plugins-1.7-2.fc21 has been pushed to the Fedora 21 stable repository. qm-vamp-plugins-1.7-2.fc20 has been pushed to the Fedora 20 stable repository. qm-vamp-plugins-1.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository. qm-vamp-plugins-1.7-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |