Spec URL: http://scientific.zcu.cz/fedora/qm-dsp-1.7-1/qm-dsp.spec SRPM URL: http://scientific.zcu.cz/fedora/qm-dsp-1.7-1/qm-dsp-1.7-1.fc21.src.rpm Description: qm-dsp is a C++ library of functions for DSP and Music Informatics purposes developed at Queen Mary, University of London. It is used by the QM Vamp Plugins (q.v.) among other things. Fedora Account System Username: valtri Packaging of qm-dsp and qm-vamp-plugins is motivated by bringing automatic tempo and beat detection to mixxx (https://bugzilla.rpmfusion.org/show_bug.cgi?id=3019). But Queen Mary Vamp plugins can do a lot more.
This one? https://code.soundsoftware.ac.uk/projects/qm-vamp-plugins/repository/revisions
Yes, that's the source code repository for qm-vamp-plugins (request #1060520). qm-dsp helper library has repository at https://code.soundsoftware.ac.uk/projects/qm-dsp/repository .
Spec URL: http://scientific.zcu.cz/fedora/qm-dsp-1.7-1b/qm-dsp.spec SRPM URL: http://scientific.zcu.cz/fedora/qm-dsp-1.7-1b/qm-dsp-1.7-1.fc22.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7236317 The "libtoolize patch" to make shared library was probably too much. This new version is nearer to upstream: it builds and provides only the static library.
Looks pretty good! The only guideline not followed I've been able to find is "All patches should have an upstream bug link or comment"[1] - can you submit qm-dsp-cxx-build.patch (or does [2] do the same?) and qm-dsp-install.patch upstream and include a link/comment? Also, it makes sense to try to be close to upstream but can you perhaps open an upstream bug for supporting shared library builds (provided qm-vamp-plugins can use it)? [1] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment [2] https://code.soundsoftware.ac.uk/projects/qm-dsp/repository/revisions/915365c58758
Thanks for taking the review! These two packages are quite interesting - the scientific research behind, the packaging (using insane Fortran math libraries :-)), and the practical application in mixxx. It looks like the cxx build is really fixed (link to upstream commit can be added). The install patch would be usefull to send. I guess the authors won't like the shared library with the PIC code much - there are quite a lot of micro-optimizations - but it can be mentioned. I had trouble with contacting upstream authors though, but I'll try again.
To be honest I'm mostly interested in the mixxx plugin:) So, can you either replace the cxx build patch with the one for upstream or include a comment, or am I being too nitpicky? I thought you could just open issues in their bug tracker but it seems that the registration open for everyone. If you sent an email already, that's good enough for me.
The new updated version: Spec URL: http://scientific.zcu.cz/fedora/qm-dsp-1.7-2/qm-dsp.spec SRPM URL: http://scientific.zcu.cz/fedora/qm-dsp-1.7-2/qm-dsp-1.7-2.fc22.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7941888 I sent email to upstream author at February, but vamp-plugins forum is probably preferred. I'll try to publish the patches there.
The new spec is fine -> ACCEPT. Thank you for packaging the library!
Patches submitted here: http://vamp-plugins.org/forum/index.php/topic,270.0.html
New Package SCM Request ======================= Package Name: qm-dsp Short Description: Library for DSP and Music Informatics purposes Upstream URL: http://isophonics.net/QMVampPlugins Owners: valtri Branches: f20 f21 el6 epel7 InitialCC:
Git done (by process-git-requests).
New Package SCM Request ======================= Package Name: qm-dsp Short Description: Library for DSP and Music Informatics purposes Upstream URL: http://isophonics.net/QMVampPlugins Owners: valtri Branches: f20 f21 el6 epel7 InitialCC: Can you check this package? I think something went wrong with qm-dsp, it isn't available yet. The other package, qm-vamp-plugins, looks OK. Thanks!
qm-dsp-1.7-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qm-dsp-1.7-2.fc21
qm-dsp-1.7-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/qm-dsp-1.7-2.fc20
qm-dsp-1.7-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/qm-dsp-1.7-2.el7
qm-dsp-1.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/qm-dsp-1.7-2.el6
qm-dsp-1.7-2.fc21 has been pushed to the Fedora 21 testing repository.
qm-dsp-1.7-2.fc21 has been pushed to the Fedora 21 stable repository.
qm-dsp-1.7-2.fc20 has been pushed to the Fedora 20 stable repository.
qm-dsp-1.7-2.el7 has been pushed to the Fedora EPEL 7 stable repository.
qm-dsp-1.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository.