Bug 106083

Summary: P2FS queue processing should be disabled for pollDelay _or_ startupDelay == 0
Product: [Retired] Red Hat Enterprise CMS Reporter: Scott Seago <sseago>
Component: otherAssignee: ccm-bugs-list
Status: CLOSED WONTFIX QA Contact: Jon Orris <jorris>
Severity: medium Docs Contact:
Priority: medium    
Version: nightly   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-03-09 15:35:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 108447    

Description Scott Seago 2003-10-02 16:32:54 UTC
Description of problem:
If p2fs pollDelay is set to 0, the thread polls continuously (i.e. "while
(Thread.sleep(0) {} ). In this case, polling should be disabled entirely (as is
done with startupDelay)

Version-Release number of selected component (if applicable):
6.0 and rickshaw

How reproducible:
always

Steps to Reproduce:
1. set pollDelay to 0
    
Actual results:
continuous polling

Expected results:
no polling

Additional info:
fixed on //cms/test-publishing at 36645

Comment 1 Daniel Berrangé 2003-10-02 17:02:39 UTC
How about we just go one better & instead of relying on magic values, just have
an obvious

  enabled = true|false;

parameter in the p2fs confige options. I'm always having to refer to the
documentation / java code to remind myself which parameter needs to be set to
'0' to disable p2fs.


Comment 2 Scott Seago 2003-10-02 17:11:22 UTC
That sounds fine. However, at least for pollDelay, if we don't disable it when
the delay is 0, we should probably override that value with some non-zero value
to avoid constant polling.