Hide Forgot
Description of problem: If p2fs pollDelay is set to 0, the thread polls continuously (i.e. "while (Thread.sleep(0) {} ). In this case, polling should be disabled entirely (as is done with startupDelay) Version-Release number of selected component (if applicable): 6.0 and rickshaw How reproducible: always Steps to Reproduce: 1. set pollDelay to 0 Actual results: continuous polling Expected results: no polling Additional info: fixed on //cms/test-publishing at 36645
How about we just go one better & instead of relying on magic values, just have an obvious enabled = true|false; parameter in the p2fs confige options. I'm always having to refer to the documentation / java code to remind myself which parameter needs to be set to '0' to disable p2fs.
That sounds fine. However, at least for pollDelay, if we don't disable it when the delay is 0, we should probably override that value with some non-zero value to avoid constant polling.