Bug 1061636

Summary: engine-log-collector help default logfile path does not make sense
Product: [Retired] oVirt Reporter: Petr Beňas <pbenas>
Component: ovirt-engine-logcollectorAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: low Docs Contact:
Priority: low    
Version: 3.4CC: ecohen, gklein, iheim, lveyde, pstehlik, rbalakri, sbonazzo, yeylon
Target Milestone: ---Keywords: Documentation
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: ovirt-3.5.0-beta2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-17 12:37:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1122965    

Description Petr Beňas 2014-02-05 09:36:28 UTC
Description of problem:
Help of the engine-log-collector contains default path for logs, which is not actually correct. The name of the log file contains date and time when was the help generated. Such a path is not actually default, since it will never exist. Therefore it makes no sense to claim it's a default path. 


Version-Release number of selected component (if applicable):
both 3.3 and 3.4 releases of log-collector

Steps to Reproduce:
1. repreat several times: engine-log-collector --help | grep '/var/log' -A 1

Actual results:
[root@vm-18-223 ~]# engine-log-collector --help | grep '/var/log' -A 1
  --log-file=PATH       path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-20140205112847.log)
[root@vm-18-223 ~]# engine-log-collector --help | grep '/var/log' -A 1
  --log-file=PATH       path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-20140205112856.log)
[root@vm-18-223 ~]# engine-log-collector --help | grep '/var/log' -A 1
  --log-file=PATH       path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-20140205112901.log)


Expected results:
path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-<TIMESTAMP>.log)
or not to report default file at all
or log to single file (not creating a new file for each run), then a default file would exist

Comment 1 Itamar Heim 2014-02-09 08:52:43 UTC
Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.

Comment 3 Sandro Bonazzola 2014-05-08 13:56:03 UTC
This is an automated message.

oVirt 3.4.1 has been released.
This issue has been retargeted to 3.5.0 since it has not been marked as high priority or severity issue, please retarget if needed.

Comment 4 Petr Beňas 2014-07-29 08:45:56 UTC
Verified in 3.5.0-0.1.master.el6

Comment 5 Sandro Bonazzola 2014-10-17 12:37:10 UTC
oVirt 3.5 has been released and should include the fix for this issue.