Bug 1061636 - engine-log-collector help default logfile path does not make sense
Summary: engine-log-collector help default logfile path does not make sense
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-logcollector
Version: 3.4
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 3.5.0
Assignee: Simone Tiraboschi
QA Contact: bugs@ovirt.org
URL:
Whiteboard: integration
Depends On:
Blocks: 1122965
TreeView+ depends on / blocked
 
Reported: 2014-02-05 09:36 UTC by Petr Beňas
Modified: 2015-01-04 23:05 UTC (History)
8 users (show)

Fixed In Version: ovirt-3.5.0-beta2
Clone Of:
Environment:
Last Closed: 2014-10-17 12:37:10 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 30116 0 master MERGED command: making default log file location generic in help text Never
oVirt gerrit 30138 0 ovirt-log-collector-3.5 MERGED command: making default log file location generic in help text Never

Description Petr Beňas 2014-02-05 09:36:28 UTC
Description of problem:
Help of the engine-log-collector contains default path for logs, which is not actually correct. The name of the log file contains date and time when was the help generated. Such a path is not actually default, since it will never exist. Therefore it makes no sense to claim it's a default path. 


Version-Release number of selected component (if applicable):
both 3.3 and 3.4 releases of log-collector

Steps to Reproduce:
1. repreat several times: engine-log-collector --help | grep '/var/log' -A 1

Actual results:
[root@vm-18-223 ~]# engine-log-collector --help | grep '/var/log' -A 1
  --log-file=PATH       path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-20140205112847.log)
[root@vm-18-223 ~]# engine-log-collector --help | grep '/var/log' -A 1
  --log-file=PATH       path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-20140205112856.log)
[root@vm-18-223 ~]# engine-log-collector --help | grep '/var/log' -A 1
  --log-file=PATH       path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-20140205112901.log)


Expected results:
path to log file (default=/var/log/ovirt-engine/ovirt-
                        log-collector/ovirt-log-collector-<TIMESTAMP>.log)
or not to report default file at all
or log to single file (not creating a new file for each run), then a default file would exist

Comment 1 Itamar Heim 2014-02-09 08:52:43 UTC
Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.

Comment 3 Sandro Bonazzola 2014-05-08 13:56:03 UTC
This is an automated message.

oVirt 3.4.1 has been released.
This issue has been retargeted to 3.5.0 since it has not been marked as high priority or severity issue, please retarget if needed.

Comment 4 Petr Beňas 2014-07-29 08:45:56 UTC
Verified in 3.5.0-0.1.master.el6

Comment 5 Sandro Bonazzola 2014-10-17 12:37:10 UTC
oVirt 3.5 has been released and should include the fix for this issue.


Note You need to log in before you can comment on or make changes to this bug.