Bug 1061649
| Summary: | Invalid description of the HDD on output | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergey V. Udaltsov <sergey.udaltsov> |
| Component: | hddtemp | Assignee: | Jaromír Cápík <jcapik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 20 | CC: | jcapik, ovasik, vg.aetera |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | hddtemp-0.3-0.31.beta15.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-15 15:01:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Please note there are 2 bad things on output: invalid character at the and, and "Serise" word. That happens because the HDD description returned by HDD is longer than 24. Changing 24 to 40 fixes both issues. Hello Sergey. You're right about the size. I've patched the code and the builds will be available in updates-testing in few minutes. Thanks for the report. Regards, Jaromir. Btw. according to the Bug 1054593, the "Serise" typo comes directly from the HW. It seems the former hddtemp maintainer decided to shrink the harddrive database so that it contains only exceptions (=drives which do not return the temperature on the commonly used array indexes 194 and 190) and that's why the model string isn't translated to the correct form suggested in the Bug 1054593. Bodhi failed to update this bug. I just submitted updates for F19 and F20. hddtemp-0.3-0.31.beta15.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/FEDORA-2014-3650/hddtemp-0.3-0.31.beta15.fc20 hddtemp-0.3-0.31.beta15.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/FEDORA-2014-3628/hddtemp-0.3-0.31.beta15.fc19 hddtemp-0.3-0.31.beta15.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. hddtemp-0.3-0.31.beta15.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: hddtemp shows garbage on output: /dev/sda: Samsung SSD 840 PRO Serise �: 41°C Version-Release number of selected component (if applicable): 0.3-beta15 How reproducible: Always Steps to Reproduce: Execute hddtemp with Samsung SSD 840 Pro Additional info: Look at the file src/sata.c. There is line 91: sata_fixstring(identify + 54, 24); This is wrong. The 2nd parameter should be 40. According to the definition of struct hd_driveid { ... unsigned char model[40]; /* 0 = not_specified */ .... (see /usr/include/linux/hdreg.h) Please release fixed RPM.