Bug 1061649 - Invalid description of the HDD on output
Summary: Invalid description of the HDD on output
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: hddtemp
Version: 20
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Jaromír Cápík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-05 10:31 UTC by Sergey V. Udaltsov
Modified: 2016-02-01 01:59 UTC (History)
3 users (show)

Fixed In Version: hddtemp-0.3-0.31.beta15.fc19
Clone Of:
Environment:
Last Closed: 2014-03-15 15:01:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Sergey V. Udaltsov 2014-02-05 10:31:43 UTC
Description of problem:
hddtemp shows garbage on output:
/dev/sda: Samsung SSD 840 PRO Serise               �: 41°C

Version-Release number of selected component (if applicable):
0.3-beta15

How reproducible:
Always

Steps to Reproduce:
Execute hddtemp with Samsung SSD 840 Pro

Additional info:
Look at the file src/sata.c. There is line 91:

sata_fixstring(identify + 54, 24);

This is wrong. The 2nd parameter should be 40. According to the definition of

struct hd_driveid {

...
unsigned char   model[40];      /* 0 = not_specified */
....

(see /usr/include/linux/hdreg.h)

Please release fixed RPM.

Comment 1 Sergey V. Udaltsov 2014-02-05 10:33:27 UTC
Please note there are 2 bad things on output: invalid character at the and, and "Serise" word. That happens because the HDD description returned by HDD is longer than 24. Changing 24 to 40 fixes both issues.

Comment 2 Jaromír Cápík 2014-03-07 19:01:56 UTC
Hello Sergey.

You're right about the size. I've patched the code and the builds will be available in updates-testing in few minutes.

Thanks for the report.

Regards,
Jaromir.

Comment 3 Jaromír Cápík 2014-03-07 19:11:03 UTC
Btw. according to the Bug 1054593, the "Serise" typo comes directly from the HW. It seems the former hddtemp maintainer decided to shrink the harddrive database so that it contains only exceptions (=drives which do not return the temperature on the commonly used array indexes 194 and 190) and that's why the model string isn't translated to the correct form suggested in the Bug 1054593.

Comment 4 Jaromír Cápík 2014-03-07 19:33:09 UTC
Bodhi failed to update this bug. I just submitted updates for F19 and F20.

Comment 5 Fedora Update System 2014-03-13 11:23:41 UTC
hddtemp-0.3-0.31.beta15.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/FEDORA-2014-3650/hddtemp-0.3-0.31.beta15.fc20

Comment 6 Fedora Update System 2014-03-13 11:24:33 UTC
hddtemp-0.3-0.31.beta15.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/FEDORA-2014-3628/hddtemp-0.3-0.31.beta15.fc19

Comment 7 Fedora Update System 2014-03-15 15:01:08 UTC
hddtemp-0.3-0.31.beta15.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2014-03-18 08:10:28 UTC
hddtemp-0.3-0.31.beta15.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.