Bug 1061690
| Summary: | RFE: Do not keep aspect ratio when Auto resize VM with window is enabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] Virtualization Tools | Reporter: | Kristof Marussy <kris7topher> | ||||
| Component: | virt-manager | Assignee: | Cole Robinson <crobinso> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | unspecified | CC: | acathrow, berrange, crobinso, gscrivan | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-02-08 15:16:22 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Thanks Kristof! I pushed your patch with some minor adjustments:
commit 256052d38964cf61d1b99d3551b4a4912de47554
Author: Kristóf Marussy <kris7topher>
Date: Wed Feb 5 13:09:53 2014 +0100
console: Improve resize-guest when scaling is enabled
|
Created attachment 859637 [details] proposed enhancement The graphical console, when scaling is enabled, aims to scale the guest while maintaining the desktop aspect ratio. However, when SPICE VM resizing is in use, this behaviour prevents the display from fully filling the available space. Maintaining the aspect ratio of resizing VMs is useless since no scaling takes place. One possible way to let VM fill the available space is by passing the size request to the display widget without any aspect ratio calculations, when VM resizing is enabled. A bare-bones implementation of this approach is attached as a patch. Another possibily is to expose a switch which disables aspect ratio keeping, independently from VM resizing. This would allow the user to let the display be distorted if no VM resizing is available. However, the benefits of this second approach are dubious.