Bug 1061690 - RFE: Do not keep aspect ratio when Auto resize VM with window is enabled
Summary: RFE: Do not keep aspect ratio when Auto resize VM with window is enabled
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-05 12:47 UTC by Kristof Marussy
Modified: 2014-02-08 15:16 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-02-08 15:16:22 UTC
Embargoed:


Attachments (Terms of Use)
proposed enhancement (1.84 KB, patch)
2014-02-05 12:47 UTC, Kristof Marussy
no flags Details | Diff

Description Kristof Marussy 2014-02-05 12:47:28 UTC
Created attachment 859637 [details]
proposed enhancement

The graphical console, when scaling is enabled, aims to scale the guest while maintaining the desktop aspect ratio. However, when SPICE VM resizing is in use, this behaviour prevents the display from fully filling the available space. Maintaining the aspect ratio of resizing VMs is useless since no scaling takes place.

One possible way to let VM fill the available space is by passing the size request to the display widget without any aspect ratio calculations, when VM resizing is enabled. A bare-bones implementation of this approach is attached as a patch.

Another possibily is to expose a switch which disables aspect ratio keeping, independently from VM resizing. This would allow the user to let the display be distorted if no VM resizing is available. However, the benefits of this second approach are dubious.

Comment 1 Cole Robinson 2014-02-08 15:16:22 UTC
Thanks Kristof! I pushed your patch with some minor adjustments:

commit 256052d38964cf61d1b99d3551b4a4912de47554
Author: Kristóf Marussy <kris7topher>
Date:   Wed Feb 5 13:09:53 2014 +0100

    console: Improve resize-guest when scaling is enabled


Note You need to log in before you can comment on or make changes to this bug.