Bug 1062319
| Summary: | Ensure "Queue" button is always visible on clone job page | ||
|---|---|---|---|
| Product: | [Retired] Beaker | Reporter: | PaulB <pbunyan> |
| Component: | web UI | Assignee: | matt jia <mjia> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 0.15 | CC: | aigao, bpeck, dcallagh, dowang, ebaak, jburke, mjia, pbunyan, qwan, rjoost, tools-bugs |
| Target Milestone: | 21.2 | Keywords: | Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-23 03:54:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
PaulB
2014-02-06 16:21:54 UTC
I guess this is really just a workaround for the fact that the job XML textarea can be taller than the browser viewport, and so when the page is scrolled down the button is no longer visible. I would rather make the textarea adjust itself to fit the browser viewport, than to keep adding more duplicate buttons all over the page. I reworded the issue title to make it clear that the goal is to ensure the "Queue" button is always visible on this page. As Dan suggests, resizing the text area to match the browser viewport height is likely a better solution to that than duplicating the button. Dan/Nick, Sounds good to me. Thank you for the response. Best, -pbunyan I would suggest to fix the submit button postion when scrolling down the page. Then it will be always visible to users. On Gerrit: http://gerrit.beaker-project.org/#/c/3250/ Cheers, Matt Jia (In reply to matt jia from comment #6) > I would suggest to fix the submit button postion when scrolling down the > page. Then it will be always visible to users. I would prefer to make the job XML textarea size itself according to the viewport, because that will also avoid the annoying problem of two independent scrollbars (one for the page, the other inside the textarea). It sounds like you want to make the textare autogrow. https://github.com/jackmoore/autosize Cheers, Matt Jia (In reply to matt jia from comment #8) > It sounds like you want to make the textare autogrow. > > https://github.com/jackmoore/autosize That plugin is pretty neat. I guess combined with a fixed-position button it would be a good solution. What I actually had in mind was just for the textarea to size itself depending on the browser viewport -- so for example if there is only 500px of vertical space for the textarea (because someone is on a low res laptop) then the textarea would size itself to fit, instead of being hardcoded to 40 rows as it is now. I'm not sure which approach is easier or better. The autosize plugin might be better since it would deal with even pathologically small browser viewports (by relying on the page scroll). I have added jQuery Autosize plugin into our git submodules. On Gerrit: http://gerrit.beaker-project.org/#/c/3258/ Cheers, Matt Jia (In reply to matt jia from comment #10) > I have added jQuery Autosize plugin into our git submodules. > > On Gerrit: > > http://gerrit.beaker-project.org/#/c/3258/ > > Cheers, Matt Jia Forget about this since it can be achieved by Boostrap "affix" plugin: On Gerrit: http://gerrit.beaker-project.org/#/c/4467/ Beaker 21.2 has been released. |