Bug 1062319 - Ensure "Queue" button is always visible on clone job page
Summary: Ensure "Queue" button is always visible on clone job page
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.15
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 21.2
Assignee: matt jia
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-06 16:21 UTC by PaulB
Modified: 2018-02-06 00:41 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-23 03:54:53 UTC
Embargoed:


Attachments (Terms of Use)

Description PaulB 2014-02-06 16:21:54 UTC
Description of problem:
 Please add/return a "Queue" button to the bottom of the Beaker clone job page, as it was in the previous Beaker version. When cloning a job in Beaker there were previously two "Queue" buttons on the clone page. One atop the clone page and one at the bottom. Beaker Version 0.15.3 has only one a the top right. 

Version-Release number of selected component (if applicable):
 Version 0.15.3


Additional info:

Comment 3 Dan Callaghan 2014-07-24 02:19:55 UTC
I guess this is really just a workaround for the fact that the job XML textarea can be taller than the browser viewport, and so when the page is scrolled down the button is no longer visible.

I would rather make the textarea adjust itself to fit the browser viewport, than to keep adding more duplicate buttons all over the page.

Comment 4 Nick Coghlan 2014-07-24 05:18:51 UTC
I reworded the issue title to make it clear that the goal is to ensure the "Queue" button is always visible on this page.

As Dan suggests, resizing the text area to match the browser viewport height is likely a better solution to that than duplicating the button.

Comment 5 PaulB 2014-07-24 12:33:02 UTC
Dan/Nick,
Sounds good to me.
Thank you for the response.

Best,
-pbunyan

Comment 6 matt jia 2014-08-14 04:17:58 UTC
I would suggest to fix the submit button postion when scrolling down the page. Then it will be always visible to users.

On Gerrit:

http://gerrit.beaker-project.org/#/c/3250/

Cheers, Matt Jia

Comment 7 Dan Callaghan 2014-08-18 01:42:10 UTC
(In reply to matt jia from comment #6)
> I would suggest to fix the submit button postion when scrolling down the
> page. Then it will be always visible to users.

I would prefer to make the job XML textarea size itself according to the viewport, because that will also avoid the annoying problem of two independent scrollbars (one for the page, the other inside the textarea).

Comment 8 matt jia 2014-08-18 02:53:19 UTC
It sounds like you want to make the textare autogrow.

https://github.com/jackmoore/autosize

Cheers, Matt Jia

Comment 9 Dan Callaghan 2014-08-18 03:00:21 UTC
(In reply to matt jia from comment #8)
> It sounds like you want to make the textare autogrow.
> 
> https://github.com/jackmoore/autosize

That plugin is pretty neat. I guess combined with a fixed-position button it would be a good solution.

What I actually had in mind was just for the textarea to size itself depending on the browser viewport -- so for example if there is only 500px of vertical space for the textarea (because someone is on a low res laptop) then the textarea would size itself to fit, instead of being hardcoded to 40 rows as it is now.

I'm not sure which approach is easier or better. The autosize plugin might be better since it would deal with even pathologically small browser viewports (by relying on the page scroll).

Comment 10 matt jia 2014-08-19 02:21:13 UTC
I have added jQuery Autosize plugin into our git submodules.

On Gerrit:

 http://gerrit.beaker-project.org/#/c/3258/

Cheers, Matt Jia

Comment 11 matt jia 2015-10-30 01:35:34 UTC
(In reply to matt jia from comment #10)
> I have added jQuery Autosize plugin into our git submodules.
> 
> On Gerrit:
> 
>  http://gerrit.beaker-project.org/#/c/3258/
> 
> Cheers, Matt Jia

Forget about this since it can be achieved by Boostrap "affix" plugin:

On Gerrit:

   http://gerrit.beaker-project.org/#/c/4467/

Comment 14 matt jia 2015-11-23 03:54:53 UTC
Beaker 21.2 has been released.


Note You need to log in before you can comment on or make changes to this bug.