Bug 1062324
| Summary: | Review Request: gstreamer1-vaapi - GStreamer plugins to use VA API video acceleration | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Simon Farnsworth <simon> |
| Component: | Package Review | Assignee: | Adam Williamson <awilliam> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | arun, awilliam, bnocera, nekohayo, package-review, tcallawa |
| Target Milestone: | --- | Flags: | awilliam:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-02-07 10:30:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Simon Farnsworth
2014-02-06 16:30:50 UTC
Yeah, since this is just passing through to libva for the work (and that is passing through to the drivers), there is no issue here. Thanks for checking though. Lifting FE-Legal. What the hell, I'll take it. Builds fine in koji on rawhide. rpmlint output looks good: [adamw@adam SRPMS]$ rpmlint gstreamer1-vaapi-0.5.8-1.fc20.src.rpm gstreamer1-vaapi.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [adamw@adam x86_64]$ rpmlint gstreamer1-vaapi-* gstreamer1-vaapi.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer 2 packages and 0 specfiles checked; 0 errors, 1 warnings. I don't see any nasties in the licensing, and spot signs off on the patent thing, so we're fine there. "MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory" - there's an auto-generated (library) dependency on gstreamer1, which owns %_libdir/gstreamer-1.0 . as these packages are very tightly coupled I think we're fine without an explicit dependency. As -devel requires the main package I'm not sure it's really necessary to dupe all the documentation, but hey, it's small. All MUST items in the guidelines look fine. Nice job, first time review pass. Package is approved. New Package SCM Request ======================= Package Name: gstreamer1-vaapi Short Description: GStreamer plugins to use VA API video acceleration Owners: farnz Branches: f20 InitialCC: Git done (by process-git-requests). I've built this for Fedora 20 and Rawhide, but testing the F20 build has shown that there's an upstream bug that I'd like to resolve before I push an update via Bodhi. Closing this bug. I tested it briefly on Rawhide and it seemed to work, FWIW - loaded an h.264 HD video in Totem and it played with <10% CPU usage (with the driver installed: I'm in Canada, I'm patent-safe :>). vainfo reports the correct capabilities. (In reply to Adam Williamson from comment #6) > I tested it briefly on Rawhide and it seemed to work, FWIW - loaded an h.264 > HD video in Totem and it played with <10% CPU usage (with the driver > installed: I'm in Canada, I'm patent-safe :>). vainfo reports the correct > capabilities. It's most dramatic if you use it with a high bitrate video (30MBit/s or more) on a CPU limited platform (like Intel Baytrail); going from 100% CPU load on all cores and lots of frame dropping to around 10% CPU usage and full frame rate is a clear and obvious improvement. FWIW, I got to the bottom of the bug I was facing, and have pushed a package in the direction of F20 (via Bodhi) - https://admin.fedoraproject.org/updates/gstreamer1-vaapi-0.5.8-3.fc20 nice! I'm actually planning to test it on baytrail today, if I ever finish shaving this yak herd. |