This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 1062324 - Review Request: gstreamer1-vaapi - GStreamer plugins to use VA API video acceleration
Review Request: gstreamer1-vaapi - GStreamer plugins to use VA API video acce...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Adam Williamson
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-06 11:30 EST by Simon Farnsworth
Modified: 2014-02-13 23:44 EST (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-02-07 05:30:15 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
awilliam: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Simon Farnsworth 2014-02-06 11:30:50 EST
Spec URL: http://90.155.96.198/sfarnsworth/gstreamer1-vaapi.spec
SRPM URL: http://90.155.96.198/sfarnsworth/gstreamer1-vaapi-0.5.8-1.fc20.src.rpm
Description: A set of GStreamer 1.x plugins for using libva (VA API) to handle video.

I'm using this in-house, so offering the package up to the wider Fedora community.

I believe that the legal issues are covered by the same reasoning as libva itself (https://bugzilla.redhat.com/show_bug.cgi?id=518546) - this package does not itself do any decoding, it simply passes video data through to libva, which then passes it to a driver that infringes patents. I'm going to block FE-LEGAL, though, so that my reasoning can be reviewed.

Fedora Account System Username: farnz
Comment 1 Tom "spot" Callaway 2014-02-06 12:10:34 EST
Yeah, since this is just passing through to libva for the work (and that is passing through to the drivers), there is no issue here. Thanks for checking though. Lifting FE-Legal.
Comment 2 Adam Williamson 2014-02-06 14:12:41 EST
What the hell, I'll take it. Builds fine in koji on rawhide. rpmlint output looks good:

[adamw@adam SRPMS]$ rpmlint gstreamer1-vaapi-0.5.8-1.fc20.src.rpm 
gstreamer1-vaapi.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[adamw@adam x86_64]$ rpmlint gstreamer1-vaapi-*
gstreamer1-vaapi.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

I don't see any nasties in the licensing, and spot signs off on the patent thing, so we're fine there.

"MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory" - there's an auto-generated (library) dependency on gstreamer1, which owns %_libdir/gstreamer-1.0 . as these packages are very tightly coupled I think we're fine without an explicit dependency.

As -devel requires the main package I'm not sure it's really necessary to dupe all the documentation, but hey, it's small.

All MUST items in the guidelines look fine. Nice job, first time review pass. Package is approved.
Comment 3 Simon Farnsworth 2014-02-06 16:07:35 EST
New Package SCM Request
=======================
Package Name: gstreamer1-vaapi
Short Description: GStreamer plugins to use VA API video acceleration
Owners: farnz
Branches: f20
InitialCC:
Comment 4 Jon Ciesla 2014-02-06 19:09:08 EST
Git done (by process-git-requests).
Comment 5 Simon Farnsworth 2014-02-07 05:30:15 EST
I've built this for Fedora 20 and Rawhide, but testing the F20 build has shown that there's an upstream bug that I'd like to resolve before I push an update via Bodhi. Closing this bug.
Comment 6 Adam Williamson 2014-02-07 12:46:07 EST
I tested it briefly on Rawhide and it seemed to work, FWIW - loaded an h.264 HD video in Totem and it played with <10% CPU usage (with the driver installed: I'm in Canada, I'm patent-safe :>). vainfo reports the correct capabilities.
Comment 7 Simon Farnsworth 2014-02-07 15:32:23 EST
(In reply to Adam Williamson from comment #6)
> I tested it briefly on Rawhide and it seemed to work, FWIW - loaded an h.264
> HD video in Totem and it played with <10% CPU usage (with the driver
> installed: I'm in Canada, I'm patent-safe :>). vainfo reports the correct
> capabilities.

It's most dramatic if you use it with a high bitrate video (30MBit/s or more) on a CPU limited platform (like Intel Baytrail); going from 100% CPU load on all cores and lots of frame dropping to around 10% CPU usage and full frame rate is a clear and obvious improvement.

FWIW, I got to the bottom of the bug I was facing, and have pushed a package in the direction of F20 (via Bodhi) - https://admin.fedoraproject.org/updates/gstreamer1-vaapi-0.5.8-3.fc20
Comment 8 Adam Williamson 2014-02-07 15:50:56 EST
nice! I'm actually planning to test it on baytrail today, if I ever finish shaving this yak herd.

Note You need to log in before you can comment on or make changes to this bug.