Bug 1064537
| Summary: | use systemd timer instead of cron job for sa-update | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomasz Torcz <tomek> | ||||||
| Component: | spamassassin | Assignee: | Kevin Fenzi <kevin> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 22 | CC: | johannbg, kevin, nb, plautrba, wtogami | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-04-03 17:41:37 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 991679 | ||||||||
| Attachments: |
|
||||||||
Created attachment 862504 [details]
sa-update.timer
Guidelines for timer units are not yet done, so I don't want to add any before that happens. Thanks much for the attachments, but please note we shouldn't apply these yet until guidelines are done. Thanks. What do you mean you wont apply these until guidelines are done? I think that statement is pretty clear? Currently timer units are not mentioned in packaging guidelines. I'd like for them to be so we know we are all doing this the same way and it's the best practice. They would likely need to be mentioned at least in: https://fedoraproject.org/wiki/Packaging:Systemd#Activation (time based activation should be added?) The start by default policy? Should timer units always be run by default, even if the service is not? Perhaps a note about not adding a dep to a package that doesn't otherwise need systemd just for a timer unit? (In reply to Kevin Fenzi from comment #4) > I think that statement is pretty clear? Read the fesco meeting from the feature proposal. That will answer your questions As well as provide you with a list of components that *might* be migrated. Components not on that list will not be migrated to timer units This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Packaging guidelines have been updated: https://fedoraproject.org/wiki/Packaging:Systemd#Timer_activation As spamassassin already ships unit file and depends on systemd, following is applicable: "must use timer units instead of cron jobs, with no dependency or requirements on a crontab" When this is done could you please keep the cron as a config boolean so the package can continue to operate when built on EL6? This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 ok. I have built and pushed to rawhide a version using timers. I'd like to let it cook there for a bit before going to stable releases. |
Created attachment 862503 [details] sa-update.service Update to 3.4.0 is a great opportunity to replace cronjob with systemd timer. So please consider attached units instead of /etc/cron.d/sa-update. Thanks.