Bug 1065401
Summary: | [RHEVH] [TUI] TUI displays column "Manged by:" incorrectly | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Martin Pavlik <mpavlik> | ||||||||||
Component: | ovirt-node-plugin-vdsm | Assignee: | Douglas Schilling Landgraf <dougsland> | ||||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Belka <jbelka> | ||||||||||
Severity: | low | Docs Contact: | |||||||||||
Priority: | unspecified | ||||||||||||
Version: | 3.3.0 | CC: | cpelland, dfediuck, dougsland, ecohen, fdeutsch, gklein, iheim, jbelka, lbopf, mpavlik, yeylon, ylavi | ||||||||||
Target Milestone: | --- | ||||||||||||
Target Release: | 3.5.2 | ||||||||||||
Hardware: | x86_64 | ||||||||||||
OS: | Linux | ||||||||||||
Whiteboard: | node | ||||||||||||
Fixed In Version: | ovirt-node-plugin-vdsm-0.1.1-15.el6ev | Doc Type: | Bug Fix | ||||||||||
Doc Text: |
Previously, the "Managed by" column displayed the Manager URL incorrectly in the Red Hat Enterprise Virtualization Hypervisor user interface. Now, the system recognizes and correctly displays the protocol used during the registration (http or https), and does not display a URL and PORT if the data is not available.
|
Story Points: | --- | ||||||||||
Clone Of: | Environment: | ||||||||||||
Last Closed: | 2015-02-26 15:34:01 UTC | Type: | Bug | ||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||
Documentation: | --- | CRM: | |||||||||||
Verified Versions: | Category: | --- | |||||||||||
oVirt Team: | Node | RHEL 7.3 requirements from Atomic Host: | |||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
Embargoed: | |||||||||||||
Bug Depends On: | |||||||||||||
Bug Blocks: | 1184995 | ||||||||||||
Attachments: |
|
Description
Martin Pavlik
2014-02-14 15:11:30 UTC
Created attachment 863314 [details]
logs
Created attachment 863315 [details]
log_collector
(In reply to Martin Pavlik from comment #0) > Created attachment 863311 [details] > screenshot 1 > > Description of problem: > TUI displays column "Manged by:" incorrectly (see screenshot 1) > > there is multiple problems with display of column managed by in TUI > > TUI shows: Managed by: oVirt engine > http://mp-rhevm33.rhev.lab.eng.brq.redhat.com:None > > Problem 1) host is added into over secure connection > > so it should be displayed as > https://mp-rhevm33.rhev.lab.eng.brq.redhat.com > not > http://mp-rhevm33.rhev.lab.eng.brq.redhat.com > Ok, attached patch. > > 2) there is suffix :None in the end of the URL > either there should be no suffix or it should be filled with something > meaningful like port number > > e.g. https://mp-rhevm33.rhev.lab.eng.brq.redhat.com:443 > We already fixed that one in another patch/bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1057453 http://gerrit.ovirt.org/#/c/24421/ fail ovirt-node-plugin-vdsm-0.1.1-19.el6ev.noarch/Red Hat Enterprise Virtualization Hypervisor release 6.5 (20140513.0.el6ev) I still see plaintext http in Status tab: Managed by: oVirt Engine http://jb-rhevm34.rhev.lab.eng.brq.redhat.com The host was added into RHEVM via 'management_server' kernel option for PXE installation. Bug 1088875 is possibly a dupe of this bug. removing UserExperience Keyword - no user experience design advice is needed here, this is just a bug in the displayed data. Hi Fabian, As we talked, can you please double check if node is not splitting such info when we provide management_server=IP_ADDRESS:PORT during autoinstall? Douglas, can you remember how and where the management_server variable is read from the cmdline and saved somewhere? Howdy Fabian, (In reply to Fabian Deutsch from comment #10) > Douglas, can you remember how and where the management_server variable is > read from the cmdline and saved somewhere? From my findings: scripts/ovirt-init-functions.sh.in I do believe it will read: /etc/ovirt-commandline.d/vdsm-reg <snip> # check the params to be ignored before adding to bootparams varname=${i%=*} if ! grep -qw $varname /etc/ovirt-commandline.d/* 2>/dev/null; then bootparams="$bootparams $i" else i=${i#$varname=} eval $varname=$i plugin_vars="$plugin_vars $varname" fi </snip> Then: ========= log "Updating $OVIRT_DEFAULTS" tmpaug=$(mktemp) for p in $params $plugin_vars; do PARAM=$(uc $p) value=$(ptr $p) if [ -n "$value" -o $p = 'init' -o $p = 'upgrade' -o $p = 'install' ]; then log "Updating OVIRT_$PARAM to '$value'" echo "set /files$OVIRT_DEFAULTS/OVIRT_$PARAM '\"$value\"'" \ >> $tmpaug fi done ovirt.log shows: ================ <snip> Updating /etc/default/ovirt Updating OVIRT_BOOTIF to 'eth0' Updating OVIRT_INIT to '/dev/sda' .. OVIRT_MANAGEMENT_SERVER to '192.168.100.228:8080' <snip> To summary, if user uses in the autoinstall the format IP:PORT as showed above we won't split OVIRT_MANAGEMENT_SERVER and the OVIRT_MANAGEMENT_PORT won't be set. TUI will show server as '192.168.100.228:8080'. Does it make sense? Thanks! Moving to assigned since the patch must be moved to a different part of source. Hi, Moving to POST as this patch is available in 3.5 and master branches. For patching node-3.0 branch requires the 3.4.z flag (patch also ready - gerrit 33352). Does this bug still exist in the 3.5 RHEV-H images? Created attachment 995664 [details]
rhevh-3.5
bug seems to be gone in Red Hat Enterprise Virtualization Hypervisor 7.0 (20150127.0.el7ev)
see attached screenshot
Thanks Martin, closing this according to comment 17 |