Bug 1066122

Summary: don't send <br> on empty lines in recipeset view
Product: [Retired] Beaker Reporter: Jiri Jaburek <jjaburek>
Component: web UIAssignee: Nick Coghlan <ncoghlan>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 0.15CC: aigao, asaha, dcallagh, llim, qwan, rmancy, xjia
Target Milestone: 0.16   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-17 03:01:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
verify none

Description Jiri Jaburek 2014-02-17 18:44:49 UTC 
Description of problem:

The issue is clearly visible on an active job with lots of tasks waiting to be processed, but it can also be seen on any aborted job (again, with many tasks).

On the task <tr> line, in third <td>, is the following content:

<td class="task" style="white-space:nowrap;">
    <span class="datetime"></span>
    <br></br>
    <span class="datetime"></span>
    <br></br>
</td>

Omitting the fact that </br> is non-standard, the actual <br> (twice) is what makes all "waiting" task table lines vertically "fat", despite there being no data.

Please adjust the page generation logic to send the <br> tags only with real data. I tried to trace the code down, but could not find source code for the WebUI - at least that particular part doesn't seem to be part of the official Beaker (server) repository.


Version-Release number of selected component (if applicable):
0.15.3
Comment 3 Nick Coghlan 2014-02-18 03:30:15 UTC 
The templates for the web UI are part of the main server code (although it certainly isn't the easiest structure to follow, since it bounces back and forth between the templates, client side Javascript and server side Python code).

In this case, the offending HTML is embedded directly in the template that is used to display the task result grid:
http://git.beaker-project.org/cgit/beaker/tree/Server/bkr/server/templates/tasks_widget.kid?id=7aaef95cf4d639102f81795a6f51e93d5fab4489#n58

It should be a relatively straightforward tweak to either avoid generating the <br/> tags entirely (and use CSS instead), or else to only emit the <br/> if there is a time to display.
Comment 5 xjia 2014-02-26 05:13:28 UTC 
Created attachment 867758 [details]
verify

Verify this bug. Have uploaded the screen shot.
Comment 6 Dan Callaghan 2014-03-17 03:01:57 UTC 
Beaker 0.16.0 has been released.