Bug 1066122 - don't send <br> on empty lines in recipeset view
Summary: don't send <br> on empty lines in recipeset view
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.15
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: 0.16
Assignee: Nick Coghlan
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-17 18:44 UTC by Jiri Jaburek
Modified: 2018-02-06 00:41 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-17 03:01:57 UTC
Embargoed:


Attachments (Terms of Use)
verify (194.33 KB, image/png)
2014-02-26 05:13 UTC, xjia
no flags Details

Description Jiri Jaburek 2014-02-17 18:44:49 UTC
Description of problem:

The issue is clearly visible on an active job with lots of tasks waiting to be processed, but it can also be seen on any aborted job (again, with many tasks).

On the task <tr> line, in third <td>, is the following content:

<td class="task" style="white-space:nowrap;">
    <span class="datetime"></span>
    <br></br>
    <span class="datetime"></span>
    <br></br>
</td>

Omitting the fact that </br> is non-standard, the actual <br> (twice) is what makes all "waiting" task table lines vertically "fat", despite there being no data.

Please adjust the page generation logic to send the <br> tags only with real data. I tried to trace the code down, but could not find source code for the WebUI - at least that particular part doesn't seem to be part of the official Beaker (server) repository.


Version-Release number of selected component (if applicable):
0.15.3

Comment 3 Nick Coghlan 2014-02-18 03:30:15 UTC
The templates for the web UI are part of the main server code (although it certainly isn't the easiest structure to follow, since it bounces back and forth between the templates, client side Javascript and server side Python code).

In this case, the offending HTML is embedded directly in the template that is used to display the task result grid:
http://git.beaker-project.org/cgit/beaker/tree/Server/bkr/server/templates/tasks_widget.kid?id=7aaef95cf4d639102f81795a6f51e93d5fab4489#n58

It should be a relatively straightforward tweak to either avoid generating the <br/> tags entirely (and use CSS instead), or else to only emit the <br/> if there is a time to display.

Comment 5 xjia 2014-02-26 05:13:28 UTC
Created attachment 867758 [details]
verify

Verify this bug. Have uploaded the screen shot.

Comment 6 Dan Callaghan 2014-03-17 03:01:57 UTC
Beaker 0.16.0 has been released.


Note You need to log in before you can comment on or make changes to this bug.