Bug 1067778

Summary: signed/unsigned comparison bug in maniadrive
Product: [Fedora] Fedora Reporter: Rob Clark <rclark>
Component: maniadriveAssignee: Hans de Goede <hdegoede>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: hdegoede
Target Milestone: ---   
Target Release: ---   
Hardware: arm   
OS: Linux   
Whiteboard:
Fixed In Version: maniadrive-1.2-57.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-03 03:10:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
make 'c' signed so comparison to EOF (-1) works as expected none

Description Rob Clark 2014-02-21 03:28:42 UTC
Created attachment 865790 [details]
make 'c' signed so comparison to EOF (-1) works as expected

not entirely sure how this works on x86, maybe char is signed there?  Attached patch fixes it.. need to figure out where to send it.

Comment 1 Hans de Goede 2014-02-21 13:16:13 UTC
Thanks for the patch, an update fixing this is on its way.

Comment 2 Fedora Update System 2014-02-21 13:43:25 UTC
maniadrive-1.2-57.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/maniadrive-1.2-57.fc20

Comment 3 Fedora Update System 2014-02-22 18:19:28 UTC
Package maniadrive-1.2-57.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing maniadrive-1.2-57.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-2953/maniadrive-1.2-57.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-03-03 03:10:13 UTC
maniadrive-1.2-57.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.