Bug 1067778 - signed/unsigned comparison bug in maniadrive
Summary: signed/unsigned comparison bug in maniadrive
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: maniadrive
Version: 20
Hardware: arm
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-02-21 03:28 UTC by Rob Clark
Modified: 2014-03-03 03:10 UTC (History)
1 user (show)

Fixed In Version: maniadrive-1.2-57.fc20
Clone Of:
Environment:
Last Closed: 2014-03-03 03:10:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
make 'c' signed so comparison to EOF (-1) works as expected (266 bytes, patch)
2014-02-21 03:28 UTC, Rob Clark
no flags Details | Diff

Description Rob Clark 2014-02-21 03:28:42 UTC
Created attachment 865790 [details]
make 'c' signed so comparison to EOF (-1) works as expected

not entirely sure how this works on x86, maybe char is signed there?  Attached patch fixes it.. need to figure out where to send it.

Comment 1 Hans de Goede 2014-02-21 13:16:13 UTC
Thanks for the patch, an update fixing this is on its way.

Comment 2 Fedora Update System 2014-02-21 13:43:25 UTC
maniadrive-1.2-57.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/maniadrive-1.2-57.fc20

Comment 3 Fedora Update System 2014-02-22 18:19:28 UTC
Package maniadrive-1.2-57.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing maniadrive-1.2-57.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-2953/maniadrive-1.2-57.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-03-03 03:10:13 UTC
maniadrive-1.2-57.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.