Bug 1068710

Summary:	Review Request: hda-verb - HD-Audio codecs Commander
Product:	[Fedora] Fedora	Reporter:	Mosaab Alzoubi <moceap>
Component:	Package Review	Assignee:	Mukundan Ragavan <nonamedotc>
Status:	CLOSED CANTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	nonamedotc, package-review
Target Milestone:	---	Flags:	nonamedotc: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-03 12:00:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mosaab Alzoubi 2014-02-21 17:47:44 UTC

Spec URL: http://ojuba.org/oji/SPECS/hda-verb.spec
SRPM URL: http://ojuba.org/oji/SRPMS/hda-verb-0.4-1.oj35.src.rpm
Description:
hda-verb is a tiny program that allows you to access the HD-audio
codecs directly, allowing you to send commands (verbs) to them. For
hda-verb to work you must be running a linux kernel with
CONFIG_SND_HDA_HWDEP option enabled.

Fedora Account System Username:moceap

Comment 1 Mukundan Ragavan 2014-02-21 17:52:19 UTC

I can take it.

Comment 2 Mosaab Alzoubi 2014-02-21 17:54:52 UTC

Thanks.

Comment 3 Mosaab Alzoubi 2014-02-21 18:07:33 UTC

somebody call me and said:
There are another package provide hda-verb, it's alsa-tools.
But it has 0.3 not 0.4 !!

Comment 4 Mukundan Ragavan 2014-02-21 18:13:34 UTC

So this package will cause a conflict then?

I will do a detailed review later today ... (forgot to mention this in my first comment).

Comment 5 Mukundan Ragavan 2014-02-23 16:52:38 UTC

from your spec file, please include the license file in %doc.

You spec file now reads as

%doc ChangeLog README

including the COPYING file, it should be

%doc ChangeLog README COPYING

Comment 6 Mosaab Alzoubi 2014-02-23 19:00:13 UTC

Ok

spec : http://ojuba.org/test/hda-verb.spec
srpm : http://ojuba.org/test/hda-verb-0.4-2.oj35.src.rpm

Comment 7 Mukundan Ragavan 2014-02-23 20:57:52 UTC

Few more comments - 

* In the %install section, can you not just use %make_install?

* To me this looks like a conflict with alsa-tools.

$ rpmls alsa-tools-1.0.27-3.fc20.x86_64.rpm
-rwxr-xr-x  /usr/bin/as10k1
-rwxr-xr-x  /usr/bin/cspctl
-rwxr-xr-x  /usr/bin/echomixer
-rwxr-xr-x  /usr/bin/envy24control
-rwxr-xr-x  /usr/bin/hda-verb        <-----
-rwxr-xr-x  /usr/bin/hdajackretask
-rwxr-xr-x  /usr/bin/hdspconf
-rwxr-xr-x  /usr/bin/hdspmixer


$ rpmls hda-verb-0.4-1.fc20.x86_64.rpm
-rwxr-xr-x  /usr/sbin/hda-verb
drwxr-xr-x  /usr/share/doc/hda-verb
-rw-r--r--  /usr/share/doc/hda-verb/ChangeLog

http://fedoraproject.org/wiki/Packaging:Conflicts

Let me know what you think.

Comment 8 Mosaab Alzoubi 2015-04-03 12:00:16 UTC

Ok, It conflicts.