Bug 1068936

Description of problem:
=======================
Packstack failed to configure ML2 to work with OVS and VLAN.
The ERROR I get:

ERROR : Error appeared during Puppet run: 192.168.160.29_neutron.pp
Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Cannot alias Package[neutron-plugin-ovs] to ["openstack-neutron-openvswitch"] at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/modules/neutron/manifests/agents/ovs.pp:129; resource ["Package", "openstack-neutron-openvswitch"] already declared at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/manifests/192.168.160.29_neutron.pp:32 at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/modules/neutron/manifests/agents/ovs.pp:129 on node <FQDN>

The answer file neutron related configuration I used:

CONFIG_NEUTRON_INSTALL=y
CONFIG_NEUTRON_SERVER_HOST=192.168.160.27
CONFIG_NEUTRON_KS_PW=123456
CONFIG_NEUTRON_DB_PW=123456
CONFIG_NEUTRON_L3_HOSTS=192.168.160.27
CONFIG_NEUTRON_L3_EXT_BRIDGE=br-ex
CONFIG_NEUTRON_DHCP_HOSTS=192.168.160.29
CONFIG_NEUTRON_LBAAS_HOSTS=192.168.160.29
CONFIG_NEUTRON_L2_PLUGIN=ml2
CONFIG_NEUTRON_METADATA_HOSTS=192.168.160.27
CONFIG_NEUTRON_METADATA_PW=123456
CONFIG_NEUTRON_ML2_TYPE_DRIVERS=vlan
CONFIG_NEUTRON_ML2_TENANT_NETWORK_TYPES=vlan
CONFIG_NEUTRON_ML2_MECHANISM_DRIVERS=openvswitch
CONFIG_NEUTRON_ML2_FLAT_NETWORKS=*
CONFIG_NEUTRON_ML2_VLAN_RANGES=int_vlan_range:208:210,int_vlan_range:185:185
CONFIG_NEUTRON_ML2_TUNNEL_ID_RANGES=
CONFIG_NEUTRON_ML2_VXLAN_GROUP=
CONFIG_NEUTRON_ML2_VNI_RANGES=
CONFIG_NEUTRON_L2_AGENT=openvswitch
CONFIG_NEUTRON_LB_TENANT_NETWORK_TYPE=local
CONFIG_NEUTRON_LB_VLAN_RANGES=
CONFIG_NEUTRON_LB_INTERFACE_MAPPINGS=
CONFIG_NEUTRON_OVS_TENANT_NETWORK_TYPE=vlan
CONFIG_NEUTRON_OVS_VLAN_RANGES=int_vlan_range:208:210,int_vlan_range:185:185
CONFIG_NEUTRON_OVS_BRIDGE_MAPPINGS=int_vlan_range:br-nodes
CONFIG_NEUTRON_OVS_BRIDGE_IFACES=
CONFIG_NEUTRON_OVS_TUNNEL_RANGES=
CONFIG_NEUTRON_OVS_TUNNEL_IF=
CONFIG_NEUTRON_OVS_VXLAN_UDP_PORT=4789

Version-Release number of selected component (if applicable):
=============================================================
openstack-packstack-2013.2.1-0.24.dev982.el6ost.noarch

How reproducible:
=================
Tested Once.

Steps to Reproduce:
===================
Use packstack with the Neutron entries I mentioned above.

Actual results:
===============
Snipped from the log:

2014-02-23 12:19:54::DEBUG::sequences::48::root:: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/packstack/installer/core/sequences.py", line 46, in run
    self.function(config)
  File "/usr/lib/python2.6/site-packages/packstack/plugins/puppet_950.py", line 187, in applyPuppetManifest
    waitforpuppet(currently_running)
  File "/usr/lib/python2.6/site-packages/packstack/plugins/puppet_950.py", line 167, in waitforpuppet
    validate_logfile(log)
  File "/usr/lib/python2.6/site-packages/packstack/modules/puppet.py", line 90, in validate_logfile
    raise PuppetError(message)
PuppetError: Error appeared during Puppet run: 192.168.160.29_neutron.pp
Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Cannot alias Package[neutron-plugin-ovs] to ["openstack-neutron-openvswitch"] at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/modules/neutron/manifests/agents/ovs.pp:129; resource ["Package", "openstack-neutron-openvswitch"] already declared at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/manifests/192.168.160.29_neutron.pp:32 at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/modules/neutron/manifests/agents/ovs.pp:129 on node <FQDN>^[[0m
You will find full trace in log /var/tmp/packstack/20140223-120038-MF9pU3/manifests/192.168.160.29_neutron.pp.log

2014-02-23 12:19:54::ERROR::run_setup::912::root:: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/packstack/installer/run_setup.py", line 907, in main
    _main(confFile)
  File "/usr/lib/python2.6/site-packages/packstack/installer/run_setup.py", line 573, in _main
    runSequences()
  File "/usr/lib/python2.6/site-packages/packstack/installer/run_setup.py", line 552, in runSequences
    controller.runAllSequences()
  File "/usr/lib/python2.6/site-packages/packstack/installer/setup_controller.py", line 84, in runAllSequences
    sequence.run(self.CONF)
  File "/usr/lib/python2.6/site-packages/packstack/installer/core/sequences.py", line 105, in run
    step.run(config=config)
  File "/usr/lib/python2.6/site-packages/packstack/installer/core/sequences.py", line 52, in run
    raise SequenceError(str(ex))
SequenceError: Error appeared during Puppet run: 192.168.160.29_neutron.pp
Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Cannot alias Package[neutron-plugin-ovs] to ["openstack-neutron-openvswitch"] at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/modules/neutron/manifests/agents/ovs.pp:129; resource ["Package", "openstack-neutron-openvswitch"] already declared at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/manifests/192.168.160.29_neutron.pp:32 at /var/tmp/packstack/fdce48249ae54e4ba1178e0fd180de3b/modules/neutron/manifests/agents/ovs.pp:129 on node <FQDN>^[[0m
You will find full trace in log /var/tmp/packstack/20140223-120038-MF9pU3/manifests/192.168.160.29_neutron.pp.log

Expected results:
=================
Packstack should install OpenStack with Neutron ML2 plugin with OVS as L2 agent and VLAN as type driver