Bug 1069493

Summary:	Review Request: uncommons-antlib - Tools for building modular software with Apache Ant
Product:	[Fedora] Fedora	Reporter:	gil cattaneo <puntogil>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mizdebsk, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-25 16:22:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description gil cattaneo 2014-02-25 06:41:21 UTC

Spec URL: http://gil.fedorapeople.org/uncommons-antlib.spec
SRPM URL: http://gil.fedorapeople.org/uncommons-antlib-0.3.2-1.fc19.src.rpm
Description:
The Uncommons Antlib provides macro definitions, custom tasks and other tools
to support the development of modular Java software using Apache Ant.  It
builds on the concepts, processes and best practices established in the
development of several Ant-based projects, particularly the Uncommons.org
open source projects.

The guiding principle behind the design of the Uncommons Antlib is convention
over configuration. Ant build scripts are greatly simplified by relying on
consistent directory structures and naming conventions.
Fedora Account System Username: gil

Comment 1 Mikolaj Izdebski 2014-02-25 16:14:47 UTC

You can require java-headless on all Fedoras, teher's no need for conditional.

Sed command to remove Class-Path should be changed to something like /Class-Path/d.  The reason is that if upstream modifies this line (which is likely as it contains dependency versions) you may easily miss this during package update, leafing to Class-Path sneaking into manifest.

Ant config file in ant.d should not list ant itself.  It should be marked as %config instead of %config(noreplace)

Comment 2 gil cattaneo 2014-02-25 16:22:16 UTC

No longer required